DataFormats/Common: change from std::swap to edm::swap #11843
Conversation
Due to a bug in ICC `std::swap` attempts to call `atomic( const atomic& ) = delete;` and fails. Using `edm::swap` does not trigger ICC to call this ctor. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_6_X. DataFormats/Common: change from std::swap to edm::swap It involves the following packages: DataFormats/Common @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
core-approved
fully-signed
tests-started
and removed
core-pending
pending-signatures
tests-pending
labels
|
-1 Tested at: 013c0d8 ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
The failure is not related to the changes. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
DataFormats/Common: change from std::swap to edm::swap
Due to a bug in ICC
std::swapattempts to callatomic( const atomic& ) = delete;and fails. Usingedm::swapdoes not trigger ICC tocall this ctor.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch