Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary include and forward declaration of RefGetter #11847

Merged
merged 1 commit into from Oct 17, 2015

Conversation

Dr15Jones
Copy link
Contributor

The edm::RefGetter class is no longer used by any code but its
include file was still being referenced in a few files.

The edm::RefGetter class is no longer used by any code but its
include file was still being referenced in a few files.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Removed unnecessary include and forward declaration of RefGetter

It involves the following packages:

DataFormats/TrackerRecHit2D
HLTrigger/special
RecoLocalTracker/SiStripRecHitConverter
RecoTracker/MeasurementDet

@perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @mschrode, @jlagram, @cerati, @gpetruc, @istaslis, @threus, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8951/console

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11847 cd768e3

Deleting unnecessary references to RefGetter. There should be no change in run-time behavior.

Compilation is successful. Jenkins tests are not really relevant, and, in this case, they show unrelated differences from several other PRs.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 17, 2015
Removed unnecessary include and forward declaration of RefGetter
@cmsbuild cmsbuild merged commit d441ef7 into cms-sw:CMSSW_7_6_X Oct 17, 2015
@Dr15Jones Dr15Jones deleted the removeRefGetterIncludes branch October 19, 2015 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants