HGC ToT Digitization Implementation (and corresponding RECO updates) #11850

lgray · 2015-10-16T12:24:02Z

This PR implements the HGCal Time-Over-Threshold digitization in CMSSW 76X.

The HGCal RecHit producers are accordingly updated.

The digitization and reconstruction chain can be tested with:
cmsRun RecoLocalCalo/HGCalRecProducers/test/testHGCalRecoLocal_cfg.py

There are a few small bugfixes to the CaloTowerHardcodeGeometryLoader to allow it to work with upgrade geometries.

New customizations are introduced to handle the HGCal. (@bsunanda please double check this)

Rechit energy and time distributions look healthy (35 gev electron gun):

…de, changing DIGI structure to reflect FE readout mode

…wVersion=2

…with respect to original toa when there is leakage/fixing bug in local variable defining TDC saturation...

…pectra

cmsbuild · 2015-10-16T12:26:13Z

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

HGC ToT Digitization Implementation (and corresponding RECO updates)

It involves the following packages:

Configuration/Geometry
DataFormats/HGCDigi
Geometry/CMSCommonData
Geometry/HcalTowerAlgo
RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers
SLHCUpgradeSimulations/Configuration
SimCalorimetry/EcalSimProducers
SimCalorimetry/HGCalSimProducers

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @cseez, @vandreev11, @sethzenz, @makortel, @kpedro88, @argiro, @Martin-Grunewald, @pfs this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

slava77 · 2015-10-16T12:42:34Z

@lgray
I see #11679 and #11801 PRs merged here

11801 was merged already and can be taken out of the history here with a rebase
11679 was fully signed for 6 days already, but not merged. Is there an issue with that PR?

lgray · 2015-10-16T12:43:51Z

@slava77 not sure if there is a problem with #11679
@davidlange6 Mind seeing if there is any show stopper?

lgray · 2015-10-16T12:44:19Z

@slava77 Will rebase when both PRs this depends on are merged into CMSSW.

bsunanda · 2015-10-16T12:46:16Z

@davidlange6 There is no issue for 11679. I wonder why it is not integrated. Same true for 11711.

From: Lindsey Gray [notifications@github.com]
Sent: 16 October 2015 14:43
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] HGC ToT Digitization Implementation (and corresponding RECO updates) (#11850)

@slava77 https://github.com/slava77 not sure if there is a problem with #11679 #11679
@davidlange6 https://github.com/davidlange6 Mind seeing if there is any show stopper?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11850#issuecomment-148706585.

davidlange6 · 2015-10-16T13:08:29Z

11711 was signed last night. I’m catching up with those this afternoon. 11679 needs a followup from me that I mentioned in the sim meeting last week

On Oct 16, 2015, at 2:46 PM, bsunanda notifications@github.com wrote:

@davidlange6 There is no issue for 11679. I wonder why it is not integrated. Same true for 11711.

From: Lindsey Gray [notifications@github.com]
Sent: 16 October 2015 14:43
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] HGC ToT Digitization Implementation (and corresponding RECO updates) (#11850)

@slava77 https://github.com/slava77 not sure if there is a problem with #11679 #11679
@davidlange6 https://github.com/davidlange6 Mind seeing if there is any show stopper?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11850#issuecomment-148706585.
—
Reply to this email directly or view it on GitHub.

lgray · 2015-10-16T13:11:25Z

@boudoul FYI

bsunanda · 2015-10-16T13:31:28Z

@davidlange6 I wonder what was the concern for 11679.

From: David Lange [notifications@github.com]
Sent: 16 October 2015 15:08
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] HGC ToT Digitization Implementation (and corresponding RECO updates) (#11850)

11711 was signed last night. I’m catching up with those this afternoon. 11679 needs a followup from me that I mentioned in the sim meeting last week

On Oct 16, 2015, at 2:46 PM, bsunanda notifications@github.com wrote:

@davidlange6 There is no issue for 11679. I wonder why it is not integrated. Same true for 11711.

From: Lindsey Gray [notifications@github.com]
Sent: 16 October 2015 14:43
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] HGC ToT Digitization Implementation (and corresponding RECO updates) (#11850)

@slava77 https://github.com/slava77 not sure if there is a problem with #11679 #11679
@davidlange6 https://github.com/davidlange6 Mind seeing if there is any show stopper?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11850#issuecomment-148706585.
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11850#issuecomment-148712180.

cmsbuild · 2015-10-16T13:48:25Z

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8953/console

lgray · 2015-10-16T13:52:07Z

Failure reason:

IOError: [Errno 28] No space left on device
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE

cmsbuild · 2015-10-16T15:28:29Z

-1
Tested at: a4f9bfe
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 16-Oct-2015 15:59:08 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 16-Oct-2015 16:02:30 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 16-Oct-2015 16:08:40 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 16-Oct-2015 16:14:11 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 16-Oct-2015 16:15:03 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 16-Oct-2015 16:19:42 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
----- Begin Fatal Exception 16-Oct-2015 16:20:17 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 16-Oct-2015 16:24:40 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log
----- Begin Fatal Exception 16-Oct-2015 16:28:54 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 16-Oct-2015 16:29:43 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 16-Oct-2015 16:32:58 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 16-Oct-2015 16:46:42 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 16-Oct-2015 16:50:41 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=EcalUncalibRecHitProducer label='ecalMultiFitUncalibRecHit'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'doEB'
 'doEE'
 'doES'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11850/8957/summary.html

lgray · 2015-10-16T15:37:32Z

Hmm this passed locally. Must have forgotten a change...

lgray · 2015-10-16T16:13:08Z

Right, this one is also waiting on #11784. (which is why I thought I fixed the problem that happened)

I will wait until that gets merged in and then rebase.

slava77 · 2015-10-19T22:19:21Z

@lgray there are merge conflicts here now

What is the plan for #11679 ?

Unless there is a big reason to have this in 760, please close this PR and let's continue in 80X cycle.

lgray · 2015-10-19T22:20:39Z

@slava77 Yes, let's continue this in 80X.

Sunanda and others added 30 commits October 7, 2015 21:31

Add a scenario with PhaseI tracker, PhaseII muon for HGCAL

cf61e18

Take care of comments from Yana

9551926

running version

2e8f48e

updating with busy flags ok

4d1b7ab

updating cfi

f236054

updating

a2152f8

running

cdc3eb6

updating for debug mode;

9071f85

modifying to use charge everywhere, including re-iteration for ToT mo…

b97d1fd

…de, changing DIGI structure to reflect FE readout mode

updating

64f8867

updating

d7e4a4f

adding extra flag to avoid ambiguity in signalling busy states

b3350bf

new stuff

b0e7e69

updating with threshold

f5f57cd

update rec hit workflow to be able to use the ADC+TDC FE

2b17a9f

understanding a crash

93e571b

fix up some leftovers from rebasing

4a30efb

now setting the time correctly

8cf5153

investigating odd issue with noise

2bd5fe3

add configurable smearing to TDC simulation, 80ps by default

8d54893

simplifying energy conversions in digi and rec hits

240d89d

updating thr for PF, fixing double counting issue for SARS ADC when f…

8835962

…wVersion=2

adding average pulse shape time in each bx bin, and removing average …

debabbd

…with respect to original toa when there is leakage/fixing bug in local variable defining TDC saturation...

removing unintentional line

8f0d879

adding toa estimate from rise time+sim hit sorting

5490bdf

normalizing pulse shape

a06c3b0

some bugs die hard

6d2a3e7

no time smearing by default

2a9ec69

add tdc onset charge offset to uncalib rechits, produces continuous s…

18d9f3a

…pectra

fix rebase issues

a330fca

cmsbuild added reconstruction-pending simulation-pending geometry-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 16, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 16, 2015

cmsbuild added tests-pending and removed tests-started labels Oct 16, 2015

cmsbuild added tests-rejected and removed tests-pending labels Oct 16, 2015

cmsbuild mentioned this pull request Oct 19, 2015

HGC ToT Digitization Implementation (and corresponding RECO updates) #11880

Merged

lgray closed this Oct 19, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HGC ToT Digitization Implementation (and corresponding RECO updates) #11850

HGC ToT Digitization Implementation (and corresponding RECO updates) #11850

lgray commented Oct 16, 2015

cmsbuild commented Oct 16, 2015

slava77 commented Oct 16, 2015

lgray commented Oct 16, 2015

lgray commented Oct 16, 2015

bsunanda commented Oct 16, 2015

davidlange6 commented Oct 16, 2015

lgray commented Oct 16, 2015

bsunanda commented Oct 16, 2015

cmsbuild commented Oct 16, 2015

lgray commented Oct 16, 2015

cmsbuild commented Oct 16, 2015

lgray commented Oct 16, 2015

lgray commented Oct 16, 2015

slava77 commented Oct 19, 2015

lgray commented Oct 19, 2015

HGC ToT Digitization Implementation (and corresponding RECO updates) #11850

HGC ToT Digitization Implementation (and corresponding RECO updates) #11850

Conversation

lgray commented Oct 16, 2015

cmsbuild commented Oct 16, 2015

slava77 commented Oct 16, 2015

lgray commented Oct 16, 2015

lgray commented Oct 16, 2015

bsunanda commented Oct 16, 2015

davidlange6 commented Oct 16, 2015

lgray commented Oct 16, 2015

bsunanda commented Oct 16, 2015

cmsbuild commented Oct 16, 2015

lgray commented Oct 16, 2015

cmsbuild commented Oct 16, 2015

lgray commented Oct 16, 2015

lgray commented Oct 16, 2015

slava77 commented Oct 19, 2015

lgray commented Oct 19, 2015