Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made static nWarn thread-safe via std::atomic #1186

Merged

Conversation

Dr15Jones
Copy link
Contributor

nWarn is used to only allow at most 5 Info messages to be sent when particilar functions are called. The static int was changed to a static std::atomic<int> so the increment is done in a thread safe manner.
The thread-safety checker says this indirectly affects 116 modules.

@Dr15Jones
Copy link
Contributor Author

@ktf this is just a trivial technical change

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Made static nWarn thread-safe via std::atomic

It involves the following packages:

TrackingTools/GsfTracking

@nclopezo, @smuzaffar, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc, @cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@slava77
Copy link
Contributor

slava77 commented Oct 27, 2013

+1

tested (sign263) in CMSSW_7_0_X_2013-10-26-1400
#1187 3739654
#1186 8c7ae33
#1180 e5f07bd
no diffs as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Oct 27, 2013
…cking

Multithreading fixes -- Made static nWarn thread-safe via std::atomic
@ktf ktf merged commit 637de88 into cms-sw:CMSSW_7_0_X Oct 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants