Changed MagFields verbose::debugOut to constexpr to avoid threading problems #1187
Conversation
…roblems The thread-safey checker complains about the static verbose::debugOut. Given that no code exists which changes the value after it is initialized changing this to a constexpr has no functional effect. The default remains the same 'false'. If one wants the debug output they have to edit the code and recompile.
|
@ktf This is purely a technical change which indirectly caused thread safety issues for 129 modules. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X. Changed MagFields verbose::debugOut to constexpr to avoid threading problems It involves the following packages: MagneticField/Layers @nclopezo, @smuzaffar, @thspeer, @slava77 can you please review it and eventually sign? Thanks. |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Multithreading fixes -- Changed MagFields verbose::debugOut to constexpr to avoid threading problems
Correlator: support for running barrel TM18
The thread-safey checker complains about the static verbose::debugOut.
Given that no code exists which changes the value after it is initialized
changing this to a constexpr has no functional effect. The default remains
the same 'false'. If one wants the debug output they have to edit the code
and recompile.