Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default HBHENoiseFilter settings to Run2-25ns configuration V2 - 76X #11912

Conversation

cmsbuild
Copy link
Contributor

This is take-2 to switch the default HBHENoiseFilterResultProducer settings to Run2-25ns configuration such that users get correct noise flags out of the box for the bulk of 2015 data (and beyond) which is with 25ns bunch spacing.
As per @slava77's request (see PR #11778 ), Eras is replaced by BunchSpacingProducer in HBHENoiseFilterResultProducer.
In the default settings, BunchSpacingProducer is enabled, which should automatically switch between Run2 50ns and 25ns settings. However, users will have to manually configure and rerun HBHENoiseFilterResultProducer in case of any Run1 50ns data analysis.
@abdoulline @igv4321 @mariadalfonso
Automatically ported from CMSSW_7_6_X #11789 (original by @dertexaner).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_8_0_X.

Switch default HBHENoiseFilter settings to Run2-25ns configuration V2 - 76X

It involves the following packages:

CommonTools/RecoAlgos
SLHCUpgradeSimulations/Configuration

@cmsbuild, @cvuosalo, @civanch, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @jhgoh, @Martin-Grunewald, @ahinzmann this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 19, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9029/console

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

@slava77
Copy link
Contributor

slava77 commented Oct 20, 2015

+1

for #11912 9acf9a8

  • the same change as in 76X
  • jenkins tests pass and comparisons with baseline show no differences

@civanch
Copy link
Contributor

civanch commented Oct 20, 2015

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 20, 2015
…ter-to-25ns-V2

Switch default HBHENoiseFilter settings to Run2-25ns configuration V2 - 76X
@cmsbuild cmsbuild merged commit 656a234 into cms-sw:CMSSW_8_0_X Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants