New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch default HBHENoiseFilter settings to Run2-25ns configuration V2 - 76X #11912
Switch default HBHENoiseFilter settings to Run2-25ns configuration V2 - 76X #11912
Conversation
…ithub.com/dertexaner/cmssw into Switch-default-HBHENoiseFilter-to-25ns-V2
A new Pull Request was created by @cmsbuild for CMSSW_8_0_X. Switch default HBHENoiseFilter settings to Run2-25ns configuration V2 - 76X It involves the following packages: CommonTools/RecoAlgos @cmsbuild, @cvuosalo, @civanch, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…ter-to-25ns-V2 Switch default HBHENoiseFilter settings to Run2-25ns configuration V2 - 76X
This is take-2 to switch the default HBHENoiseFilterResultProducer settings to Run2-25ns configuration such that users get correct noise flags out of the box for the bulk of 2015 data (and beyond) which is with 25ns bunch spacing.
As per @slava77's request (see PR #11778 ), Eras is replaced by BunchSpacingProducer in HBHENoiseFilterResultProducer.
In the default settings, BunchSpacingProducer is enabled, which should automatically switch between Run2 50ns and 25ns settings. However, users will have to manually configure and rerun HBHENoiseFilterResultProducer in case of any Run1 50ns data analysis.
@abdoulline @igv4321 @mariadalfonso
Automatically ported from CMSSW_7_6_X #11789 (original by @dertexaner).