Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim: HF: use shower library also for run1 #11916

Merged
merged 4 commits into from Oct 22, 2015
Merged

Fastsim: HF: use shower library also for run1 #11916

merged 4 commits into from Oct 22, 2015

Conversation

cmsbuild
Copy link
Contributor

rebase of #11674
Automatically ported from CMSSW_7_6_X #11783 (original by @lveldere).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_8_0_X.

Fastsim: HF: use shower library also for run1

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/Event
SLHCUpgradeSimulations/Configuration

@cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm, @makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9044/console

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

@lveldere
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Oct 21, 2015

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 22, 2015
Fastsim: HF: use shower library also for run1
@cmsbuild cmsbuild merged commit f8ad597 into cms-sw:CMSSW_8_0_X Oct 22, 2015
@lveldere lveldere deleted the fastsim-hf-sl-run1-take2 branch November 9, 2015 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants