Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add castor geometry files with position for 2015 #11928

Closed
wants to merge 1 commit into from

Conversation

cmsbuild
Copy link
Contributor

This PR is complementary to the other two recent PRs for CASTOR (#10259, #10216).
The changed add 3 castor.xml files:

  1. One with the measured position by the positioning sensors
  2. Same as (1) plus an upward shift within the sys uncertainty
  3. Same as (2) but with downward shift.

The files are in separate folders. Hope this is OK but simple renaming could not be done because of the namespace "castor:" used by DDL.

FSQ Group wants to request simulations with these files.
Thank you.
Automatically ported from CMSSW_7_6_X #11730 (original by @cbaus).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_8_0_X.

Add castor geometry files with position for 2015

It involves the following packages:

Geometry/ForwardCommonData

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Oct 19, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8992/console

@cmsbuild
Copy link
Contributor Author

-1

Tested at: a9da6fa
I found errors in the following addon tests:

cmsRun /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2015-10-18-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Mon Oct 19 12:08:44 2015-date Mon Oct 19 12:07:46 2015 s - exit: 23552

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11928/8992/summary.html

@cmsbuild
Copy link
Contributor Author

@ianna
Copy link
Contributor

ianna commented Oct 20, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9043/console

@cmsbuild
Copy link
Contributor Author

@ianna
Copy link
Contributor

ianna commented Nov 10, 2015

@davidlange6 and @civanch - as discussed at Sim meeting new geometry payloads are in DB.
These will be three additional scenarios with labels: CastorMeasured, CastorSystPlus and CastorSystMinus.
Which GTs should be updated - all for 80x, 76x, 75x and 71x?

@mmusich - FYI.

@mmusich
Copy link
Contributor

mmusich commented Nov 10, 2015

@diguida @franzoni you are insterested as well

@mmusich
Copy link
Contributor

mmusich commented Nov 10, 2015

@ianna, can you clarify the need to update all the GTs in the currently active releases?

@davidlange6
Copy link
Contributor

@ianna - the labels correspond to three different castor geometries - which geometry was used as the starting point for adding those?

On Nov 10, 2015, at 3:39 PM, Ianna Osborne notifications@github.com wrote:

@davidlange6 and @civanch - as discussed at Sim meeting new geometry payloads are in DB.
These will be three additional scenarios with labels: CastorMeasured, CastorSystPlus and CastorSystMinus.
Which GTs should be updated - all for 80x, 76x, 75x and 71x?

@mmusich - FYI.


Reply to this email directly or view it on GitHub.

@ianna
Copy link
Contributor

ianna commented Nov 10, 2015

@davidlange6 - Extended2015dev is a starting point.

@davidlange6
Copy link
Contributor

i think Extended2015 should be instead. presumably these are for MC samples corresponding to what we currently use in production plus castor..

On Nov 10, 2015, at 4:59 PM, Ianna Osborne notifications@github.com wrote:

@davidlange6 - Extended2015dev is a starting point.


Reply to this email directly or view it on GitHub.

@ianna
Copy link
Contributor

ianna commented Nov 10, 2015

@mmusich - there will be a request for producing samples, but I'm not sure which CMSSW version will be used. Hence my question to @davidlange6 and @civanch

@diguida
Copy link
Contributor

diguida commented Nov 10, 2015

@ianna @davidlange6 the Extended2015dev is the label for SIM geometries to be tested in the shadows of the "default" scenario. And I will not advise to do this in releases older than 80X.

@civanch
Copy link
Contributor

civanch commented Nov 10, 2015

Hi all, a lot of Castor geometry fixes were introduced in dev, recent 3 version of geometries were done as 3 various shifts of this dev geometry. How to call correctly these geometries I am not sure, for me "dev" inside the label will be misleading even if files are taken from dev.

Concerning releases: production will be first requested in 7_1, we cannot exclude further requests in 7_5.

@ianna
Copy link
Contributor

ianna commented Nov 11, 2015

@davidlange6 and @civanch - default GT for MC in 71x uses the following tag: XMLFILE_Geometry_2015_72YV5_Extended2015_mc

The following payloads based on it (produced with CMSSW_7_2_5 plus this PR):

XMLFILE_Geometry_2015_72YV6_Extended2015CastorMeasured_mc
XMLFILE_Geometry_2015_72YV6_Extended2015CastorSystMinus_mc
XMLFILE_Geometry_2015_72YV6_Extended2015CastorSystPlus_mc

The following payloads based on latest Extended2015 scenario which include Hcal and Tracker parameters (produced with recent CMSSW_8_0_X IB plus this PR):

XMLFILE_Geometry_80YV1_Extended2015CastorMeasured_mc
XMLFILE_Geometry_80YV1_Extended2015CastorSystMinus_mc
XMLFILE_Geometry_80YV1_Extended2015CastorSystPlus_mc

Tracker parameters were introduced in 75x, Hcal parameters in 76x. So, the second bunch can be used in all releases. The first one only in 71x and 72x.

@cbaus
Copy link

cbaus commented Nov 12, 2015

Thank @ianna, this sounds good. Also 7_6 is possible, right? A rereco is planned in 7_6 but it's unclear to me if ever a SIM step will be done in 7_6.

@davidlange6, can you sign this PR and the ones in other versions or is there still something to do?

@ianna
Copy link
Contributor

ianna commented Nov 13, 2015

@cbaus - does castor reco geometry change in every case?

@cbaus
Copy link

cbaus commented Nov 13, 2015

@hvanhaev (@iik1997)
Hans, do you know if RECO Geometry is influenced by this? I assume this could change, e.g., the eta of a channel, then again, this might be hardcoded. If you don't know by hard, let me check this in the code.

@hvanhaev
Copy link
Contributor

Hi Colin,

I’m not sure what you mean?
But I think the RECO geometry is hardcoded, at least in the part of code that I wrote :-)
There are some hardcoded conversions to address phi and z values to RecHits…
And I guess the DetId should also be the same…
as long as the simulation response goes into the correct channel/DetId I think it is ok.

Cheers,
Hans

On 13 Nov 2015, at 19:23, cbaus <notifications@github.commailto:notifications@github.com> wrote:

@hvanhaevhttps://github.com/hvanhaev (@iik1997https://github.com/iik1997)
Hans, do you know if RECO Geometry is influenced by this? I assume this could change, e.g., the eta of a channel, then again, this might be hardcoded. If you don't know by hard, let me check this in the code.


Reply to this email directly or view it on GitHubhttps://github.com//pull/11928#issuecomment-156508578.

@cbaus
Copy link

cbaus commented Nov 16, 2015

OK then it is not necessary for RECO. Thanks.

@davidlange6
Copy link
Contributor

I believe this is superceded by @ianna PR.

@cbaus
Copy link

cbaus commented Nov 16, 2015

Could you please point me to the PR? Thanks a lot. Somehow I don't have it on my radar.
Does it also exist for the 7_X versions?

@ianna
Copy link
Contributor

ianna commented Nov 16, 2015

@cbaus The PR #12350 includes this one. It's been merged to 80x. I did not back port it.

@cbaus
Copy link

cbaus commented Nov 17, 2015

@ianna Is it possible to do so? Can I help?
(7_1, 7_5, 7_6)

@ianna
Copy link
Contributor

ianna commented Nov 17, 2015

@cbaus Thanks. I think, backporting it is not necessary. Altered position geometry scenarios will be available from GT through customization commands --geometry "DB:Extended2015CastorSystPlus", --geometry "DB:Extended2015CastorSystMinus", or --geometry "DB:Extended2015CastorMeasured"

They are already in DB and a new MC GTs for all releases have been requested. @mmusich and @diguida can give you more details on when this will be available.

@cbaus
Copy link

cbaus commented Nov 17, 2015

That's great news. Thank you.

@sebaur
Copy link

sebaur commented Jan 19, 2016

I would like to come back on this. I am trying to find appropriate GTs that include the new tags mentioned above. I found 76X_mcRun2_asymptotic_v14 for 7_6_X but was not able to find any for 7_1_X. @mmusich, @diguida could you point me to a GT that would work for 7_1_X? Thank you!

@mmusich
Copy link
Contributor

mmusich commented Jan 19, 2016

@sebaur an appropriate GT with these extensions for 71X doesn't exist yet. Let me come back to you once this becomes available.

@mmusich
Copy link
Contributor

mmusich commented Jan 19, 2016

out of curiosity, why 71X though?

@sebaur
Copy link

sebaur commented Jan 19, 2016

we need new MC production with the updated CASTOR position, standard 13 Tev pp GEN-SIM production is still in 71X ...

@franzoni
Copy link

hello @sebaur

71 is the release used for the mainstream GEN-SIM production.

What analyses need the updated castor geometry ?
I assume that such analyses won't need to mix samples from the "mainstream" castor geometry
with others with the updated castor geometry; if that's the case, 75x is a GEN-SIM validated release used for production (only of Heavy Ion datasets),
can you consider shifting your focus t0 75x ? From the AlCa/Db perspective, that would remove overhead of having to deal with dbv1 and focus on more modern infrastructure.

Cheers, @mmusich @franzoni

@sebaur
Copy link

sebaur commented Jan 19, 2016

hello @franzoni , all,
Thanks for the clarification. Our idea was to be as close to the mainstream production as possible. I will check with the other people involved and evaluate what our possibilities are. Maybe 75 is indeed a good alternative.
Thank you so far!

@mmusich
Copy link
Contributor

mmusich commented Jan 19, 2016

@sebaur in any case the updated 71X Global Tags with the requested content in terms of Geometry are available in this PR #12993
I've add the following tags:

XMLFILE_Geometry_2015_72YV6_Extended2015CastorMeasured_mc
XMLFILE_Geometry_2015_72YV6_Extended2015CastorSystMinus_mc
XMLFILE_Geometry_2015_72YV6_Extended2015CastorSystPlus_mc

with labels Extended2015CastorMeasured, Extended2015CastorSystMinus and ``Extended2015CastorSystPlus`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants