Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFormats/EcalDigi: remove intrusive macros breaking libstdc++ #11951

Merged
merged 1 commit into from Oct 19, 2015
Merged

DataFormats/EcalDigi: remove intrusive macros breaking libstdc++ #11951

merged 1 commit into from Oct 19, 2015

Commits on Oct 19, 2015

  1. DataFormats/EcalDigi: remove intrusive macros breaking libstdc++ 

    We cannot redefine 'private' and 'protected' keywords via macros to e.g.
'public'. This is extremely intrusive and breaks encapsulation.

This does not work anymore with new libstdc++ libraries, because foward
delcaration of struct is implicitly private and then implementation is
under explicit private clause. Redefining 'private' only change one of
them thus creating compile-time errors in sstream.

Details in PR65899 (GCC BZ). It's WONTFIX.

Such cleanups are required for GCC 5 and above.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Oct 19, 2015
    Copy the full SHA
    ec0978f View commit details
    Browse the repository at this point in the history