Remove intrusive macros breaking libstdc++

[davidlt]

We cannot redefine 'private' and 'protected' keywords via macros to e.g.
'public'. This is extremely intrusive and breaks encapsulation.

This does not work anymore with new libstdc++ libraries, because foward
delcaration of struct is implicitly private and then implementation is
under explicit private clause. Redefining 'private' only change one of
them thus creating compile-time errors in sstream.

Details in PR65899 (GCC BZ). It's WONTFIX.

Such cleanups are required for GCC 5 and above.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

Remove intrusive macros breaking libstdc++

It involves the following packages:

RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTriplets
TrackingTools/PatternTools

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @jhgoh, @cerati, @gpetruc, @istaslis, @trocino, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[VinInn]

+1
thanks for taking care.
like the format namespace test {namespace XYZ{void test();}}} as well

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9018/console

[cmsbuild]

+1
Tested at: 4553968
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11953/9018/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11953/9018/summary.html

[slava77]

+1

for #11953 4553968

• technical change, implemented as described
• jenkinst tests pass; no differences in comparisons

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1