Fireworks/Core: remove intrusive macros breaking libstdc++

[davidlt]

We cannot redefine 'private' and 'protected' keywords via macros to e.g.
'public'. This is extremely intrusive and breaks encapsulation.

This does not work anymore with new libstdc++ libraries, because foward
delcaration of struct is implicitly private and then implementation is
under explicit private clause. Redefining 'private' only change one of
them thus creating compile-time errors in sstream.

Details in PR65899 (GCC BZ). It's WONTFIX.

Such cleanups are required for GCC 5 and above.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

Fireworks/Core: remove intrusive macros breaking libstdc++

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[davidlt]

This was done by making setData as a public API.

@osschar

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9013/console

[cmsbuild]

+1
Tested at: fc43e33
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11957/9010/summary.html

[cmsbuild]

+1
Tested at: fc43e33
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11957/9013/summary.html

[osschar]

-1
I have all the changes ready on my desktop ... they were also tested there :)
I still have to try the latest thing by Philippe, not destroying TStyles/TCollor array on TApplication recreation but I can not do this this week.
I propose we postpone this until I'm back, early next week.

[davidlt]

This PR only covers unit tests, which do not depend on ROOT stuff.

[osschar]

Ah, ok ... sorry about that :)