Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eras for TSG tests #11981

Merged
merged 1 commit into from Oct 20, 2015
Merged

Conversation

Martin-Grunewald
Copy link
Contributor

Switch to Eras for TSG tests

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_6_X.

Eras for TSG tests

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@geoff-smith, @jalimena this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9053/console

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 20, 2015
@cmsbuild cmsbuild merged commit 0200960 into cms-sw:CMSSW_7_6_X Oct 20, 2015
@davidlt
Copy link
Contributor

davidlt commented Oct 21, 2015

Shouldn't we do that for RelVals also?

I see the following in IB RelVal logs:


    #
    # -- Warning! You are using a deprecated customisation function. --
    #
    # It will probably run fine, but the customisations you are getting may be out of date.
    # You should update your configuration file by
    #   If using cmsDriver:
    #       1) remove the "--customise SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns" option
    #       2) add the option "--era Run2_50ns"
    #   If using a pre-made configuration file:
    #       1) remove or comment out the "process = customisePostLS1_50ns(process)" line.
    #       2) add "from Configuration.StandardSequences.Eras import eras" to the TOP of the config file (above
    #          the process declaration).
    #       3) add "eras.Run2_50ns" as a parameter to the process object, e.g. "process = cms.Process('HLT',eras.Run2_50ns)"
    #
    # There is more information at https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCmsDriverEras
    #

@Martin-Grunewald
Copy link
Contributor Author

Yes - I'd thought this was already done and I was just being late...

@davidlange6
Copy link
Contributor

hum - we it was working for a moment (as few workflows aside)

On Oct 21, 2015, at 8:24 AM, davidlt notifications@github.com wrote:

Shouldn't we do that for RelVals also?

I see the following in IB RelVal logs:

#
# -- Warning! You are using a deprecated customisation function. --
#
# It will probably run fine, but the customisations you are getting may be out of date.
# You should update your configuration file by
#   If using cmsDriver:
#       1) remove the "--customise SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns" option
#       2) add the option "--era Run2_50ns"
#   If using a pre-made configuration file:
#       1) remove or comment out the "process = customisePostLS1_50ns(process)" line.
#       2) add "from Configuration.StandardSequences.Eras import eras" to the TOP of the config file (above
#          the process declaration).
#       3) add "eras.Run2_50ns" as a parameter to the process object, e.g. "process = cms.Process('HLT',eras.Run2_50ns)"
#
# There is more information at https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCmsDriverEras
#


Reply to this email directly or view it on GitHub.

@Martin-Grunewald Martin-Grunewald deleted the ErasForTSGtests branch October 21, 2015 07:01
@davidlt
Copy link
Contributor

davidlt commented Oct 21, 2015

git gripping shows that deprecated stuff is used in various tests, documentations, etc.

What I see in RelVals comes from:

Configuration/PyReleaseValidation/python/relval_steps.py:861:                                    {'--customise': 'SLHCUpgradeSimulations/Configuration/postLS1CustomsPreMixing.customisePostLS1_50ns'},

I guess.

@davidlange6
Copy link
Contributor

yes - that is one piece that is left..

On Oct 21, 2015, at 9:01 AM, davidlt notifications@github.com wrote:

git gripping shows that deprecated stuff is used in various tests, documentations, etc.

What I see in RelVals comes from:

Configuration/PyReleaseValidation/python/relval_steps.py:861: {'--customise': 'SLHCUpgradeSimulations/Configuration/postLS1CustomsPreMixing.customisePostLS1_50ns'},

I guess.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants