Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packed gen particle copy and move ctors #12000

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 20, 2015

Pr #11706 created explicit copy and move constructors for pat::PackedGenParticle.
Unfortunately, the packed quantities were left out, so they were neither moved nor copied.
This PR fixes that, and also enhances the unit test so that this would have been caught.
This fixes the discrepancy recently seen in PackedGenParticle.

@wmtan
Copy link
Contributor Author

wmtan commented Oct 20, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 20, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9076/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_6_X.

Fix packed gen particle copy and move ctors

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

What about the operator=?

@wmtan
Copy link
Contributor Author

wmtan commented Oct 20, 2015

@Dr15Jones OK, I need to fix operator(s) = also.

@wmtan
Copy link
Contributor Author

wmtan commented Oct 20, 2015

@Dr15Jones @davidlange6 I updated this PR both to fix the assignment operators and to use the
CMS_THREAD_GUARD macro to avoid the build warnings.

@wmtan
Copy link
Contributor Author

wmtan commented Oct 20, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #12000 was updated. @vadler, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor

@vadler, @monttj @davidlange6 this is critical for fixing a bug already in the release

davidlange6 added a commit that referenced this pull request Oct 21, 2015
…tors

Fix packed gen particle copy and move ctors
@davidlange6 davidlange6 merged commit 69b9e4c into cms-sw:CMSSW_7_6_X Oct 21, 2015
@wmtan wmtan deleted the FixPackedGenParticleCopyAndMoveCtors branch October 23, 2015 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants