Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of relative imports. #12016

Merged
merged 1 commit into from Oct 29, 2015

Conversation

ericvaandering
Copy link
Contributor

Python 3 will not allow them. Correct them all to use absolute imports

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ericvaandering (Eric Vaandering) for CMSSW_8_0_X.

Get rid of relative imports.

It involves the following packages:

CondCore/TagCollection
FWCore/GuiBrowsers
PhysicsTools/PythonAnalysis
Utilities/RelMon
Utilities/ReleaseScripts

@smuzaffar, @diguida, @cvuosalo, @cerminar, @monttj, @cmsbuild, @franzoni, @Dr15Jones, @slava77, @vadler, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @wmtan, @ahinzmann, @wddgit, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9100/console

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

+1

for #12016 3bb4f98

  • technical change is applied as described (only +60 −35 lines changed in 25 files after whitespaces are ignored)
  • jenkins tests pass and comparisons with baseline show no differences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants