Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed avgfedDigiOccvsLumi ME #12021

Merged
merged 1 commit into from Oct 29, 2015
Merged

fixed avgfedDigiOccvsLumi ME #12021

merged 1 commit into from Oct 29, 2015

Conversation

threus
Copy link
Contributor

@threus threus commented Oct 21, 2015

Fixed for Pixel DQM (online only): FED digi occupancy vs Lumi plot

  • starting lumisection now uses the actual LS value, instead of counting from zero
  • plot resolution changed from 10 LS to 5 LS (doubling the number of bins)

will this PR be automatically merged for 80X as well?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @threus for CMSSW_7_6_X.

fixed avgfedDigiOccvsLumi ME

It involves the following packages:

DQM/SiPixelMonitorDigi

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Oct 28, 2015

please test

@deguio
Copy link
Contributor

deguio commented Oct 28, 2015

+1
as soon as it is merged in 76 will be ported to 80 automagically.
do we have an equivalent PR for 75 as well?

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9299/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 29, 2015
@cmsbuild cmsbuild merged commit 20fed42 into cms-sw:CMSSW_7_6_X Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants