Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing relval missing new ECAL digi params (80X) #12027

Merged
merged 1 commit into from Oct 22, 2015
Merged

Fix failing relval missing new ECAL digi params (80X) #12027

merged 1 commit into from Oct 22, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Oct 21, 2015

Fix issue in one relval introduced by #11915.

@lgray
Copy link
Contributor Author

lgray commented Oct 21, 2015

@cmsbuild please test

@lgray lgray changed the title Fix failing relval missing new ECAL digi params Fix failing relval missing new ECAL digi params (80X) Oct 21, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Oct 21, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9108/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_0_X.

Fix failing relval missing new ECAL digi params (80X)

It involves the following packages:

SimGeneral/DataMixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray lgray mentioned this pull request Oct 21, 2015
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: 95328e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12027/9108/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12027/9108/summary.html

davidlange6 added a commit that referenced this pull request Oct 22, 2015
@davidlange6
Merge pull request #12027 from lgray/fix_ecaldigitizer_datamix
720eb29 
Fix failing relval missing new ECAL digi params (80X)
@davidlange6 davidlange6 merged commit 720eb29 into cms-sw:CMSSW_8_0_X Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available orp-pending pending-signatures simulation-pending tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lgray @cmsbuild @davidlange6