New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ROOT histogram fitting to be thread-safe #12032
Set ROOT histogram fitting to be thread-safe #12032
Conversation
In order to fit different root histograms on different threads one must call the undocumented function TMinuitMinimizer::UseStaticMinuit and pass it false. This will fix crashes seen in the CMSSW_7_6 IBs.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X. Set ROOT histogram fitting to be thread-safe It involves the following packages: RecoHI/HiTracking @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 Fix to make ROOT histogram fitting thread-safe to prevent crashes. There should be no change in monitored quantities. #12031 is the 76X version of this PR, and it's already been approved by Reco. The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2015-10-21-1100 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Set ROOT histogram fitting to be thread-safe
In order to fit different root histograms on different threads one
must call the undocumented function TMinuitMinimizer::UseStaticMinuit
and pass it false.
This will fix crashes seen in the CMSSW_7_6 IBs.