Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #include directives #1205

Merged
merged 1 commit into from Oct 28, 2013
Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 28, 2013

fix #include directives of the form

include "string.h"

include "vector"

into

include <cstring>

include <vector>

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_0_X.

fix #include directives

It involves the following packages:

DQM/SiStripCommon
DQMOffline/Trigger
CondCore/HcalPlugins
CondFormats/PhysicsToolsObjects
DQMServices/Diagnostic
RecoTracker/ConversionSeedGenerators
DQM/SiStripMonitorDigi
RecoLocalMuon/RPCRecHit
PhysicsTools/RooStatsCms
Alignment/MuonAlignmentAlgorithms
CondTools/SiStrip
DPGAnalysis/Skims
RecoHI/HiJetAlgos
RecoLocalTracker/SiStripClusterizer
CalibTracker/SiPixelTools
L1Trigger/CSCTrackFinder
Utilities/Timing
RecoVertex/KalmanVertexFit
TopQuarkAnalysis/TopSkimming
Alignment/CocoaAnalysis
CondTools/Hcal
RecoMET/METAlgorithms
DQMOffline/Muon
GeneratorInterface/PyquenInterface
DQM/HcalMonitorClient
RecoMuon/MuonSeedGenerator
RecoLocalCalo/EcalDeadChannelRecoveryAlgos
Alignment/CocoaModel
CaloOnlineTools/HcalOnlineDb
DQM/HLTEvF
CalibCalorimetry/EcalLaserAnalyzer
L1Trigger/GlobalMuonTrigger
Alignment/CocoaFit
OnlineDB/CSCCondDB
DQM/SiStripHistoricInfoClient
HeavyIonsAnalysis/Configuration

@vciulli, @smuzaffar, @apfeiffer1, @Dr15Jones, @ktf, @vlimant, @demattia, @danduggan, @rovere, @mulhearn, @franzoni, @thspeer, @rcastello, @deguio, @slava77, @ggovi, @vadler, @eliasron, @fabiocos, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @TaiSakuma, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@nclopezo
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
4.22
4.53
1001.0
1000.0

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1044/summary.html

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 28, 2013

Hi David,
all errors are due to DBS timeouts:

status: fail, reason: client timeout after 347 sec

.A

On 28 October 2013 18:24, David Mendez notifications@github.com wrote:

-1
When I ran the RelVals I found an error in the following worklfows:
4.22
4.53
1001.0
1000.0

you can see the results of the tests here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1044/summary.html


Reply to this email directly or view it on GitHubhttps://github.com//pull/1205#issuecomment-27234134
.

@vadler
Copy link

vadler commented Oct 28, 2013

+1

@ktf
Copy link
Contributor

ktf commented Oct 28, 2013

Bypassing. For the record: @nclopezo is a bot since a couple of days... Will become part of cmsbuild soon.

ktf added a commit that referenced this pull request Oct 28, 2013
Misc cleanups -- Fix #include directives
@ktf ktf merged commit 5eae842 into cms-sw:CMSSW_7_0_X Oct 28, 2013
@fwyzard fwyzard deleted the fix_include_directive branch November 3, 2013 15:44
EmyrClement pushed a commit to EmyrClement/cmssw that referenced this pull request Feb 14, 2024
Rewrite linpuppi emulator with ap_fixed (14_0_0_pre3 branch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants