Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-hcx44 Add protection to HcalTopology #12057

Merged
merged 1 commit into from Oct 27, 2015

Conversation

bsunanda
Copy link
Contributor

LUT code calls function for invalid DetId and then tests if it is valid DetId. Protection nee

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_7_6_X.

bsunanda:Run2-hcx44 Add protection to HcalTopology

It involves the following packages:

Geometry/CaloTopology

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9141/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

@civanch @ianna Please take look at this urgently in view of 7_6 release


From: cmsbuild [notifications@github.com]
Sent: 23 October 2015 01:34
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx44 Add protection to HcalTopology (#12057)

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12057/9141/summary.html


Reply to this email directly or view it on GitHubhttps://github.com//pull/12057#issuecomment-150385479.

@davidlt
Copy link
Contributor

davidlt commented Oct 24, 2015

Add reference to the issue: #11979

@davidlt
Copy link
Contributor

davidlt commented Oct 27, 2015

ping^1

davidlange6 added a commit that referenced this pull request Oct 27, 2015
bsunanda:Run2-hcx44 Add protection to HcalTopology
@davidlange6 davidlange6 merged commit 6895a28 into cms-sw:CMSSW_7_6_X Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants