Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New clang checker #1208

Merged
merged 5 commits into from Oct 30, 2013
Merged

New clang checker #1208

merged 5 commits into from Oct 30, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Oct 28, 2013

No description provided.

@ktf
Copy link
Contributor

ktf commented Oct 29, 2013

Can you provide instructions (even just a comment to this pull request) on how to use it? Thanks.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

New clang checker

It involves the following packages:

Utilities/StaticAnalyzers

@smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@gartung
Copy link
Member Author

gartung commented Oct 29, 2013

On 10/29/2013 3:05 AM, Giulio Eulisse wrote:

Can you provide instructions (even just a comment to this pull
request) on how to use it? Thanks.


Reply to this email directly or view it on GitHub
#1208 (comment).

USER_LLVM_CHECKERS="-enable-checker cms.FunctionChecker" scram b checker

@gartung
Copy link
Member Author

gartung commented Oct 29, 2013

On 10/29/2013 3:05 AM, Giulio Eulisse wrote:

Can you provide instructions (even just a comment to this pull
request) on how to use it? Thanks.


Reply to this email directly or view it on GitHub
#1208 (comment).

If you want to run ClassChecker , which limits the checks to data
classes see the script
Utilities/StaticAnalyzers/scripts/run_class_checker.sh
which will copy the needed classes.txt to ${CMSSW_BASE}/tmp/classes.txt

@ktf
Copy link
Contributor

ktf commented Oct 29, 2013

@nclopezo can you try to see if you manage to get a list of issues from Patrick instructions?

…mespace

and used in FunctionDumper and FunctionCheker to print function arg types
@cmsbuild
Copy link
Contributor

Pull request #1208 was updated. @smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

@nclopezo
Copy link
Contributor

Hi,

I checked out some random packages in my local environment with this pull request

DataFormats/FWLite
FWCore/Version
RecoLocalCalo/CaloRecCandCreator
RecoLocalCalo/Castor
RecoLocalCalo/Configuration
RecoLocalCalo/EcalDeadChannelRecoveryAlgos
RecoLocalCalo/EcalRecAlgos
RecoLocalCalo/EcalRecProducers
RecoLocalCalo/HcalLaserReco
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
Utilities/StaticAnalyzers

then I ran

USER_LLVM_CHECKERS="-enable-checker cms.FunctionChecker" scram b checker

and you can see the results here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/pr1208/llvm-analysis/2013-10-30-1/

Is this ok? or should I run it with other packages as well?

@ktf
Copy link
Contributor

ktf commented Oct 30, 2013

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/pr1208/llvm-analysis/2013-10-30-1/

Is this ok? or should I run it with other packages as well?

Can you update the jenkins rule to always run also this checker? I'll now merge
this.

ktf added a commit that referenced this pull request Oct 30, 2013
Improved Tools -- Static analyser to find functions that access statics.
@ktf ktf merged commit fc5c89c into cms-sw:CMSSW_7_0_X Oct 30, 2013
@Dr15Jones
Copy link
Contributor

@gartung Patrick, how is this change meant to be used?

@gartung
Copy link
Member Author

gartung commented Oct 30, 2013

Really ClassChecker should be run instead of FunctionChecker
The following two commands are need to run ClassChecker

cp -p ${CMSSW_BASE}/src/Utilities/StaticAnalyzers/scripts/classes.txt ${CMSSW_BASE}/tmp/classes.txt
USER_LLVM_CHECKERS="-enable-checker optional.ClassChecker" scram b checker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants