New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full5x5 shower shape block to non-GED photons producer #12087
Add full5x5 shower shape block to non-GED photons producer #12087
Conversation
A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_6_X. Add full5x5 shower shape block to non-GED photons producer It involves the following packages: RecoEgamma/EgammaPhotonProducers @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 For Heavy Ions, adding full5x5 shower shape to non-GED photons. #12086 and #12085 are the 75X and 80X versions of this PR, and they have already been approved by Reco. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-11-04-1100 show no significant differences, except for the expected addition of the shower shapes. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
I am cleaning up the 76x queue aside from things for analysis workflows. I'm closing this pull request, please make sure the PR is in 80x. Thanks! |
76X backport of #12085