Fail at run time if Service uses an obsolete signal. #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The threaded framework requires Services to switch to a new collection of signals. To allow easier migration, the obsolete signals have been replaced with a class which causes an Exception to be thrown if their connect method is called. Had to change one unit test which was making use of the old signals.
|
+1 |
ktf
added a commit
that referenced
this pull request
Oct 28, 2013
Fail at run time if Service uses an obsolete signal.
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
EmyrClement
pushed a commit
to EmyrClement/cmssw
that referenced
this pull request
Feb 21, 2024
…pre3 Triplet emulator 14 0 0 pre3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The threaded framework requires Services to switch to a new collection
of signals. To allow easier migration, the obsolete signals have been
replaced with a class which causes an Exception to be thrown if their
connect method is called.
Had to change one unit test which was making use of the old signals.