CondFormats/Common: remove intrusive macros breaking libstdc++

[davidlt]

We cannot redefine 'private' and 'protected' keywords via macros to e.g.
'public'. This is extremely intrusive and breaks encapsulation.

This does not work anymore with new libstdc++ libraries, because foward
delcaration of struct is implicitly private and then implementation is
under explicit private clause. Redefining 'private' only change one of
them thus creating compile-time errors in sstream.

Details in PR65899 (GCC BZ). It's WONTFIX.

Such cleanups are required for GCC 5 and above.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_8_0_X.

CondFormats/Common: remove intrusive macros breaking libstdc++

It involves the following packages:

CondFormats/Common

@diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: 5627df6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12091/9187/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12091/9187/summary.html

[davidlt]

@diguida @ggovi @davidlange6 could we get this one it? It is waiting for <2 weeks and this the last non-Fireworks piece.

[davidlt]

ping^1