use dedicated calibrations at HLT #12100

fwyzard · 2015-10-26T16:02:41Z

modify the GenericMVAJetTagComputers adding a label to choose calibrations
customise the CombinedSecondaryVertexESProducer to read b-tagging calibrations with the "HLT" label
customise the PFProducer to read the PF calibrations with the "HLT" label

…abel

fwyzard · 2015-10-26T16:03:35Z

This pull request updates #12044 and #12062 to actually pick up the calibrations with the "HLT" label

cmsbuild · 2015-10-26T16:06:11Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_6_X.

use dedicated calibrations at HLT

It involves the following packages:

HLTrigger/Configuration
RecoBTag/SecondaryVertex
RecoBTau/JetTagComputer

@perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @Martin-Grunewald, @jalimena, @ferencek, @pvmulder, @geoff-smith this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

cmsbuild · 2015-10-26T16:16:13Z

Pull request #12100 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

cmsbuild · 2015-10-26T16:31:10Z

Pull request #12100 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

cmsbuild · 2015-10-26T16:56:19Z

Pull request #12100 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

slava77 · 2015-10-26T17:13:47Z

can this be added to #12062 instead?
otherwise, #12062 should be closed

slava77 · 2015-10-26T17:14:54Z

@fwyzard
Andrea, since you are still updating this PR, please trigger tests when you are done.

- rename private variables to match CMSSW coding conventions - add a label to choose which calibrations to use

…ibrations with the "HLT" label

cmsbuild · 2015-10-26T17:21:19Z

Pull request #12100 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

fwyzard · 2015-10-26T17:23:11Z

+1

fwyzard · 2015-10-26T17:23:15Z

please test

fwyzard · 2015-10-26T17:23:46Z

@slava77 , my preliminary tests pass, I think you can double check that I didn't break anything.

cmsbuild · 2015-10-26T17:26:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9206/console

mmusich · 2015-10-26T17:27:32Z

@pvmulder @diguida

diguida · 2015-10-27T17:31:38Z

@fwyzard in #12114 we have added the new MC GT.
If you want the latest state of the art, please cherry pick mmusich@bee66c2

cmsbuild · 2015-10-27T18:26:20Z

-1
Tested at: cb1273c
The relvals timed out after 2 hours.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12100/9236/summary.html

slava77 · 2015-10-28T01:56:46Z

@cmsbuild please test
maybe no timeout this time

cmsbuild · 2015-10-28T02:01:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9249/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9261/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9266/console

davidlange6 · 2015-10-28T13:22:27Z

cmsbuild, please test
trying again..

slava77 · 2015-10-28T14:06:57Z

@cmsbuild please test
maybe this works

fwyzard · 2015-10-28T14:23:04Z

@davidlange6 just let me know if I should rebase this on top of CMSSW_7_6_X and/or update it to #12114 .

slava77 · 2015-10-28T16:51:37Z

(tests restarted manually from jenkins interface)

davidlange6 · 2015-10-28T16:55:23Z

which they already had been… lets see if something is successful...

On Oct 28, 2015, at 5:51 PM, Slava Krutelyov notifications@github.com wrote:

(tests restarted manually from jenkins interface)

—
Reply to this email directly or view it on GitHub.

slava77 · 2015-10-28T17:08:10Z

indeed, I see https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9261 was started from ib-any-integration task by Alessandro and looks like it will finish soon.
I usually submit from ib-schedule-pr-tests

cmsbuild · 2015-10-28T18:35:46Z

+1
Tested at: cb1273c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12100/9261/summary.html

cmsbuild · 2015-10-28T19:14:52Z

+1
Tested at: cb1273c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12100/9266/summary.html

cmsbuild · 2015-10-28T19:48:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12100/9261/summary.html

davidlange6 · 2015-10-28T20:26:04Z

no effect on reco quantities - (minimal changes to hlt histograms)

use dedicated calibrations at HLT

cmsbuild · 2015-10-28T20:52:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12100/9266/summary.html

slava77 · 2015-10-28T22:31:28Z

+1

for #12100 cb1273c
confirming the diffs are in HLT only

customise the PFProducer to read the PF calibrations with the "HLT" l…

94971d4

…abel

cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 26, 2015

cmsbuild added reconstruction-pending hlt-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 26, 2015

fwyzard force-pushed the HLT_use_dedicated_calibrations branch from d84c89a to 95f4e1c Compare October 26, 2015 16:12

fwyzard force-pushed the HLT_use_dedicated_calibrations branch from dc53925 to 7d6939a Compare October 26, 2015 16:30

fwyzard force-pushed the HLT_use_dedicated_calibrations branch from 37f5ad6 to 5bffee5 Compare October 26, 2015 16:54

fwyzard added 2 commits October 26, 2015 18:20

GenericMVAJetTagComputer: add a label to choose calibrations

c43a59a

- rename private variables to match CMSSW coding conventions - add a label to choose which calibrations to use

customise the CombinedSecondaryVertexESProducer to read b-tagging cal…

eb202c2

…ibrations with the "HLT" label

fwyzard force-pushed the HLT_use_dedicated_calibrations branch from 5bffee5 to eb202c2 Compare October 26, 2015 17:20

fwyzard mentioned this pull request Oct 26, 2015

Use old b-tag training at HLT in 76X #12062

Closed

cmsbuild added hlt-approved and removed hlt-pending labels Oct 26, 2015

cmsbuild added the alca-approved label Oct 27, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 27, 2015

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Oct 28, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 28, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 28, 2015

davidlange6 added a commit that referenced this pull request Oct 28, 2015

Merge pull request #12100 from fwyzard/HLT_use_dedicated_calibrations

0454537

use dedicated calibrations at HLT

davidlange6 merged commit 0454537 into cms-sw:CMSSW_7_6_X Oct 28, 2015

fwyzard deleted the HLT_use_dedicated_calibrations branch October 29, 2015 10:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use dedicated calibrations at HLT #12100

use dedicated calibrations at HLT #12100

fwyzard commented Oct 26, 2015

fwyzard commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

slava77 commented Oct 26, 2015

slava77 commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

fwyzard commented Oct 26, 2015

fwyzard commented Oct 26, 2015

fwyzard commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

mmusich commented Oct 26, 2015

diguida commented Oct 27, 2015

cmsbuild commented Oct 27, 2015

slava77 commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

davidlange6 commented Oct 28, 2015

slava77 commented Oct 28, 2015

fwyzard commented Oct 28, 2015

slava77 commented Oct 28, 2015

davidlange6 commented Oct 28, 2015

slava77 commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

davidlange6 commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

slava77 commented Oct 28, 2015

use dedicated calibrations at HLT #12100

use dedicated calibrations at HLT #12100

Conversation

fwyzard commented Oct 26, 2015

fwyzard commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

slava77 commented Oct 26, 2015

slava77 commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

fwyzard commented Oct 26, 2015

fwyzard commented Oct 26, 2015

fwyzard commented Oct 26, 2015

cmsbuild commented Oct 26, 2015

mmusich commented Oct 26, 2015

diguida commented Oct 27, 2015

cmsbuild commented Oct 27, 2015

slava77 commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

davidlange6 commented Oct 28, 2015

slava77 commented Oct 28, 2015

fwyzard commented Oct 28, 2015

slava77 commented Oct 28, 2015

davidlange6 commented Oct 28, 2015

slava77 commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

davidlange6 commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

slava77 commented Oct 28, 2015