Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalibCalorimetry/EcalLaserAnalyzer: disable object I/O (ClassDef) #12121

Merged
merged 1 commit into from Oct 28, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Oct 27, 2015

Having classes based on TObject without ClassDef creates issues while
creating a dictionary. According to CVS these files were introduced 6
years and 4 months ago and already had ClassDef commented out.
ClassVersionID is set to 0 because I/O is not needed for these
control classes.

CVS history:http://cvs.web.cern.ch/cvs/cgi-bin/viewcvs.cgi/CMSSW/CalibCalorimetry/EcalLaserAnalyzer/interface/
ROOT ClassDef documentation: https://root.cern.ch/root/Using.html

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Having classes based on `TObject` without `ClassDef` creates issues while
creating a dictionary. According to CVS these files were introduced 6
years and 4 months ago and already had `ClassDef` commented out.
`ClassVersionID` is set to **0** because I/O is not needed for these
control classes.

CVS history:http://cvs.web.cern.ch/cvs/cgi-bin/viewcvs.cgi/CMSSW/CalibCalorimetry/EcalLaserAnalyzer/interface/
ROOT `ClassDef` documentation: https://root.cern.ch/root/Using.html

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

CalibCalorimetry/EcalLaserAnalyzer: disable object I/O (ClassDef)

It involves the following packages:

CalibCalorimetry/EcalLaserAnalyzer

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Oct 27, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9237/console

@diguida
Copy link
Contributor

diguida commented Oct 27, 2015

+1
back-port of #12115

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 28, 2015
CalibCalorimetry/EcalLaserAnalyzer: disable object I/O (ClassDef)
@cmsbuild cmsbuild merged commit 8dbaa61 into cms-sw:CMSSW_7_6_X Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants