Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniAOD event content updates for 76X #12122

Merged
merged 4 commits into from Oct 28, 2015

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Oct 27, 2015

Include a few extra quantities on miniAOD:

there will be another PR adding a few other bools to the CSCHaloData format, but that won't conflict with this PR

should we save the bunch spacing also on AOD?
even if it can be recomputed easily, it may be convenient to have it stored anyway (e.g. for people using fwlite), and the disk size cost is zero.

the branch merges also cleanly in 8_0_X: should I make a separate PR or is the auto-forward-port enabled between 7_6_X and 8_0_X?

@mariadalfonso @arizzi

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_6_X.

MiniAOD event content updates for 76X

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 27, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9234/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@gpetruc - yes forward porting will take care
Could you add the bunch spacing to the AOD?

davidlange6 added a commit that referenced this pull request Oct 28, 2015
MiniAOD event content updates for 76X
@davidlange6 davidlange6 merged commit 7bfe79f into cms-sw:CMSSW_7_6_X Oct 28, 2015
@@ -55,6 +58,8 @@
'keep *_TriggerResults_*_*', # for MET filters (a catch all for the moment, but ideally it should be only the current process)
'keep patPackedCandidates_lostTracks_*_*',
'keep HcalNoiseSummary_hcalnoise__*',
'keep recoCSCHaloData_CSCHaloData_*_*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is not saved in AOD.
So, an application running on AOD will not be able to get the objects.
Since the product is needed mainly on data, it may make sense to add it to the AOD event content, otherwise it's lost.

@gpetruc gpetruc deleted the MiniAOD-eventContent-76X branch June 1, 2016 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants