Dropped unnecessary signal connections in PrescaleService #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PrescaleService told the system it wanted to listen to some obsolete signals but in reality it ignored them. Dropping the empty functions and their registration now makes the service threaded framework compatible.
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
|
-1 ===== Test "testORA_6" ==== CORAL/RelationalPlugins/oracle Error ORA-00600: internal error code, arguments: [ktspfmdb:objdchk_kcbnew_3], [1], [3912232], [4], [], [], [], [], [], [], [], [] (executing the bulk operation statement) *** Break *** segmentation violation =========================================================== There was a crash. This is the entire stack trace of all threads: =========================================================== #0 0x0000003217299db5 in waitpid () from /lib64/libc.so.6 #1 0x000000321723c761 in do_system () from /lib64/libc.so.6 #2 0x00002ad5bf789ddf in TUnixSystem::StackTrace() () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-10-28-0200/external/slc5_amd64_gcc481/lib/libCore.so #3 0x00002ad5bf78b8dc in TUnixSystem::DispatchSignals(ESignals) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-10-28-0200/external/slc5_amd64_gcc481/lib/libCore.so #4 #5 0x00002ad5be18f502 in ora::Record::destroy() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #6 0x00002ad5be18f539 in ora::Record::~Record() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #7 0x00002ad5be154b48 in ora::InsertCache::~InsertCache() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #8 0x00002ad5be154d40 in ora::MultiRecordInsertOperation::~MultiRecordInsertOperation() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #9 0x00002ad5be154e09 in ora::MultiRecordInsertOperation::~MultiRecordInsertOperation() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #10 0x00002ad5be1929ae in ora::RelationalBuffer::clear() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #11 0x00002ad5be192ab4 in ora::RelationalBuffer::~RelationalBuffer() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #12 0x00002ad5be127137 in ora::DatabaseContainer::flush() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #13 0x00002ad5be11da69 in ora::Container::flush() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #14 0x0000000000407272 in ora::Test6::execute(std::string const&) () #15 0x0000000000408e7b in ora::TestBase::run() () #16 0x000000000040391e in main () =========================================================== The lines below might hint at the cause of the crash. If they do not help you then please submit a bug report at http://root.cern.ch/bugs. Please post the ENTIRE stack trace from above as an attachment in addition to anything else that might help us fixing this issue. =========================================================== #5 0x00002ad5be18f502 in ora::Record::destroy() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #6 0x00002ad5be18f539 in ora::Record::~Record() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #7 0x00002ad5be154b48 in ora::InsertCache::~InsertCache() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #8 0x00002ad5be154d40 in ora::MultiRecordInsertOperation::~MultiRecordInsertOperation() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #9 0x00002ad5be154e09 in ora::MultiRecordInsertOperation::~MultiRecordInsertOperation() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #10 0x00002ad5be1929ae in ora::RelationalBuffer::clear() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #11 0x00002ad5be192ab4 in ora::RelationalBuffer::~RelationalBuffer() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #12 0x00002ad5be127137 in ora::DatabaseContainer::flush() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #13 0x00002ad5be11da69 in ora::Container::flush() () from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-28-0200/lib/slc5_amd64_gcc481/libCondCoreORA.so #14 0x0000000000407272 in ora::Test6::execute(std::string const&) () #15 0x0000000000408e7b in ora::TestBase::run() () #16 0x000000000040391e in main () =========================================================== ---> test testORA_6 had ERRORS you can see the results of the tests here: |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
|
@nclopezo David, please rerun the test since I don't believe the code I changed is even present in that test. |
ktf
added a commit
that referenced
this pull request
Oct 30, 2013
Multithreading fixes -- Dropped unnecessary signal connections in PrescaleService
aloeliger
added a commit
to aloeliger/cmssw
that referenced
this pull request
Mar 11, 2024
Adding the NNVtx model files for IB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PrescaleService told the system it wanted to listen to some obsolete signals but in reality it ignored them. Dropping the empty functions and their registration now makes the service threaded framework compatible.