Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Level-1 Trigger changes for HI Firmware (75X backport of #12176) #12183

Merged
merged 3 commits into from Nov 7, 2015
Merged

Level-1 Trigger changes for HI Firmware (75X backport of #12176) #12183

merged 3 commits into from Nov 7, 2015

Conversation

harmonicoscillator
Copy link
Contributor

75X backport of #12176

We expect to take take with 75X, so this backport is the most important.

R. Alex Barbieri added 2 commits October 29, 2015 19:44
Update 75X to 76X status in one go
a0dfd4a
Merged HI_L1_FirmwareDevel_75X from repository richard-cms
48a3c47 
* richard-cms/HI_L1_FirmwareDevel_75X:
  Update 75X to 76X status in one go
  Update VtxSmearedParameters_cfi.py
  Added a parameter in the Harvester to avoid considering LS which have a too small sigmaZ values. Default cut is at 1 cm
  Added a parameter in the Harvester to avoid considering LS which have a too small sigmaZ values. Default cut is at 1 cm
  Added a parameter in the Harvester to avoid considering LS which have a too small sigmaZ values. Default cut is at 1 cm
  Added a parameter in the Harvester to avoid considering LS which have a too small sigmaZ values. Default cut is at 1 cm
  Adding a vertex smearing configution for pp at 5 TeV
  fixed copy behavior for ecal rechit
  fixed save digi behavior to check for end of list
  Set ROOT histogram fitting to be thread-safe
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Oct 29, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_5_X.

Level-1 Trigger changes for HI Firmware (75X backport of #12176)

It involves the following packages:

CondFormats/L1TObjects
L1Trigger/L1TCalorimeter

@diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@harmonicoscillator harmonicoscillator mentioned this pull request Oct 29, 2015
Closed
@mulhearn
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9357/console

@cmsbuild
Copy link
Contributor

+1
Tested at: a0dfd4a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12183/9357/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12183/9357/summary.html

@mmusich
Copy link
Contributor

mmusich commented Nov 3, 2015

@cmsbuild please acknowledge changes

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

Pull request #12183 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Nov 3, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9441/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

+1
Tested at: 045e305
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12183/9441/summary.html

@mulhearn
Copy link
Contributor

mulhearn commented Nov 3, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12183/9441/summary.html

@harmonicoscillator
Copy link
Contributor Author

Is there anything else we need to get this merged into 75X? @mulhearn

@mulhearn mulhearn mentioned this pull request Nov 5, 2015
Closed
@harmonicoscillator
Copy link
Contributor Author

We really really want this to end up in 7_5_5, is there anything I can do to help that?

@davidlange6
Copy link
Contributor

+1
These can be made easier to review if the new functionality is separated from the variable renaming

davidlange6 added a commit that referenced this pull request Nov 7, 2015
@davidlange6
Merge pull request #12183 from richard-cms/HI_L1_FirmwareDevel_75X
67f9f8f 
Level-1 Trigger changes for HI Firmware (75X backport of #12176)
@davidlange6 davidlange6 merged commit 67f9f8f into cms-sw:CMSSW_7_5_X Nov 7, 2015
@mulhearn mulhearn mentioned this pull request Nov 11, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending comparison-available db-pending l1-approved new-package-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harmonicoscillator @cmsbuild @mulhearn @mmusich @davidlange6