Made LockService thread safe #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LockService should not be used in the threaded framework but getting it working may help with migration. The scoped_lock was removed since it was being updated each call and therefore was not safe if multiple modules are running concurrently. Instead we directly call ‘lock()’ and ‘unlock()’.
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
ktf
added a commit
that referenced
this pull request
Oct 30, 2013
Multithreading fixes -- Made LockService thread safe
aloeliger
added a commit
to aloeliger/cmssw
that referenced
this pull request
Mar 11, 2024
Fix GT producer for new e/g hw interfaces and update emulator patterns for new recipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LockService should not be used in the threaded framework but getting it working may help with migration. The scoped_lock was removed since it was being updated each call and therefore was not safe if multiple modules are running concurrently. Instead we directly call ‘lock()’ and ‘unlock()’.