Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74x Fireworks: Add option to skip filter items in table view #12195

Merged
merged 11 commits into from Dec 16, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented Oct 30, 2015

With this change you can disable drawing of collection entries in table view which do not pass filter.
This is per collection feature and can be set in the 'Filter' tab of collection controller.

The feature was requested by Colin Bernet.

Test osx tarball:
https://amraktad.web.cern.ch/amraktad/cmsShow-7.4-table.mac.tar.gz

@alja
Copy link
Contributor Author

alja commented Oct 30, 2015

Example of ECalFromPFCands

default filter setting

screen shot 2015-10-29 at 10 05 58 pm

changing collection filter settings

The collection has 200 entries, but only the one passing the filter are drawn
screen shot 2015-10-29 at 10 06 13 pm

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_4_X.

74x Fireworks: Add option to skip filter items in table view

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja
Copy link
Contributor Author

alja commented Oct 30, 2015

-1 waiting for response

@alja
Copy link
Contributor Author

alja commented Nov 2, 2015

-1
need to undo changes from unittests

@alja
Copy link
Contributor Author

alja commented Nov 13, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9716/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #12195 was updated. @cmsbuild, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Dec 16, 2015
74x Fireworks: Add option to skip filter items in table view
@davidlange6 davidlange6 merged commit ab1876d into cms-sw:CMSSW_7_4_X Dec 16, 2015
@alja alja deleted the table-filter branch May 11, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants