Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for adding the cfi of HITrackClusterRemover.cc for ConfDB use in 74 #12220

Merged
merged 1 commit into from
Nov 3, 2015

Conversation

ginnocen
Copy link
Contributor

Hello,

We would ask to PR the following modification in order to be able to use the HITrackClusterRemover
in ConfDB for HLT tracking. The PR consist of the corresponding cfi file and a small modification in the producer as a protection in case of null string in the oldClusterRemovalInfo.

Thanks, Cheers, Gian Michele

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ginnocen for CMSSW_7_4_X.

PR for adding the cfi of HITrackClusterRemover.cc for ConfDB use in 74

It involves the following packages:

RecoLocalTracker/SubCollectionProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @jlagram, @gpetruc, @cerati, @threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Nov 1, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9406/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2015

@slava77
Copy link
Contributor

slava77 commented Nov 2, 2015

not a -1
we do not expect any changes needed for HI algorithms in 74X.
HI data and MC processing will happen in 75X (both online and offline).

complain if there is a need for 74X
... from the ORP: the cfi is needed for HLT confDB parsing

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 3, 2015

+1

For #12220 c2d44ed

Adding Python cfi for HITrackClusterRemover.cc for ConfDB use. There should be no change in monitored quantities. #12221 and #12222 are the 75X and 76X versions of this PR, and the latter has been approved by Reco.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-10-31-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 3, 2015
PR for adding the cfi of HITrackClusterRemover.cc for ConfDB use in 74
@cmsbuild cmsbuild merged commit 06f4f69 into cms-sw:CMSSW_7_4_X Nov 3, 2015
cmsbuild added a commit that referenced this pull request Nov 3, 2015
PR for adding the cfi of HITrackClusterRemover.cc for ConfDB use in 76 (same as #12220)
cmsbuild added a commit that referenced this pull request Nov 3, 2015
PR for adding the cfi of HITrackClusterRemover.cc for ConfDB use in 75 (same as #12220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants