-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for adding the cfi of HITrackClusterRemover.cc for ConfDB use in 74 #12220
Conversation
A new Pull Request was created by @ginnocen for CMSSW_7_4_X. PR for adding the cfi of HITrackClusterRemover.cc for ConfDB use in 74 It involves the following packages: RecoLocalTracker/SubCollectionProducers @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
not a -1 complain if there is a need for 74X |
+1 Adding Python cfi for HITrackClusterRemover.cc for ConfDB use. There should be no change in monitored quantities. #12221 and #12222 are the 75X and 76X versions of this PR, and the latter has been approved by Reco. The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-10-31-2300 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
PR for adding the cfi of HITrackClusterRemover.cc for ConfDB use in 74
PR for adding the cfi of HITrackClusterRemover.cc for ConfDB use in 76 (same as #12220)
PR for adding the cfi of HITrackClusterRemover.cc for ConfDB use in 75 (same as #12220)
Hello,
We would ask to PR the following modification in order to be able to use the HITrackClusterRemover
in ConfDB for HLT tracking. The PR consist of the corresponding cfi file and a small modification in the producer as a protection in case of null string in the oldClusterRemovalInfo.
Thanks, Cheers, Gian Michele