Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade AMPT to v2.25t5 #12225

Merged
merged 3 commits into from Nov 10, 2015
Merged

Conversation

kurtejung
Copy link
Contributor

75x extension to PRs #11701 (76x) and #11932 (80x)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2015

A new Pull Request was created by @kurtejung (Kurt Jung) for CMSSW_7_5_X.

upgrade AMPT to v2.25t5

It involves the following packages:

GeneratorInterface/AMPTInterface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@covarell
Copy link
Contributor

covarell commented Nov 3, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9433/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@kurtejung - are the issues brought up with #11932 addressed in a different pr?

@kurtejung
Copy link
Contributor Author

@davidlange6 - no not yet - these will need to be addressed very carefully
since they involve directly toying with AMPT's base code. I will create
another PR to address these concerns in the next few days (hopefully by the
end of the weekend)

On Fri, Nov 6, 2015 at 7:45 AM, David Lange notifications@github.com
wrote:

@kurtejung https://github.com/kurtejung - are the issues brought up
with #11932 #11932 addressed in a
different pr?


Reply to this email directly or view it on GitHub
#12225 (comment).

@davidlange6
Copy link
Contributor

ok - thanks - we can backport once they are fixed.

@kurtejung
Copy link
Contributor Author

added new PR to address compiler warnings: #12323

@kurtejung
Copy link
Contributor Author

not sure if my comments on github show up when i reply directly - in any
case, the compiler warnings have been addressed

On Fri, Nov 6, 2015 at 5:37 PM, David Lange notifications@github.com
wrote:

ok - thanks - we can backport once they are fixed.


Reply to this email directly or view it on GitHub
#12225 (comment).

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

Pull request #12225 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please check and sign again.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9620/console

davidlange6 added a commit that referenced this pull request Nov 10, 2015
@davidlange6 davidlange6 merged commit 10ca840 into cms-sw:CMSSW_7_5_X Nov 10, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants