Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade AMPT to v2.25t5 #11932

Merged
merged 1 commit into from Nov 2, 2015
Merged

Conversation

cmsbuild
Copy link
Contributor

Implementation of latest version of AMPT to include stability enhancements when running at LHC energies. See changelog here: http://myweb.ecu.edu/linz/ampt/
Automatically ported from CMSSW_7_6_X #11701 (original by @kurtejung).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_8_0_X.

upgrade AMPT to v2.25t5

It involves the following packages:

GeneratorInterface/AMPTInterface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

This was referenced Nov 1, 2015
@bendavid
Copy link
Contributor

bendavid commented Nov 2, 2015

+1
This should eventually be moved to an external, but ok for now since needed for the very-soon HI run.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9409/console

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 2, 2015

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 2, 2015

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 2, 2015
@cmsbuild cmsbuild merged commit 4be17af into cms-sw:CMSSW_8_0_X Nov 2, 2015
@davidlt
Copy link
Contributor

davidlt commented Nov 3, 2015

Could you clean up 127 warnings from GeneratorInterface/AMPTInterface ? E.g., https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc493/CMSSW_8_0_DEVEL_X_2015-11-02-2300/GeneratorInterface/AMPTInterface

All seem to be from Fortran.

@kurtejung
Copy link
Contributor

these warnings will be addressed shortly - as discussed in #12225, they need to be done carefully as we need to ensure AMPT is not broken by assigning initialization values to variables

@kurtejung
Copy link
Contributor

Hi all - I've addressed the compiler warnings in this PR: #12323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants