Monitoring service changes for DAQ: rebase (80X)

[smorovic]

Changes in FastMonitoringService:

• C++ style const-correct casts
• void* --> const void*
• expand to 64 reserved fields in microstatelegend
• static const int instead of preprocessor definitions

this PR is a followup of changes suggested in #12138

[cmsbuild]

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_8_0_X.

Monitoring service changes for DAQ: rebase (80X)

It involves the following packages:

EventFilter/Utilities

@mommsen, @cvuosalo, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9450/console

[cmsbuild]

+1
Tested at: 6aa77b2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12245/9450/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12245/9450/summary.html

[mommsen]

+1

[cvuosalo]

+1

For #12245 6aa77b2

Code clean-up of DAQ FastMonitoringService. There should be no change in monitored quantities.

This PR should be merged after #12202 and #12148, which also include FastMonitoringService.cc but without some fixes.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2015-11-03-1100 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1