Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a utility for efficiently copying multiple files to the local #12257

Merged
merged 1 commit into from Nov 11, 2015

Conversation

bbockelm
Copy link
Contributor

@bbockelm bbockelm commented Nov 4, 2015

disk using "best practices" for reading from the local SE.

Ideally, this can be used for merging log files (which are not ROOT
format) from the local SE.

disk using "best practices" for reading from the local SE.

Ideally, this can be used for merging log files (which are not ROOT
format) from the local SE.
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_6_X.

Provide a utility for efficiently copying multiple files to the local

It involves the following packages:

IOPool/Common

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

-1
Brian, please make this for CMSSW_8_0. Also I don't think this belongs on IOPool/Common since it has nothing to do with PoolSource or PoolOutputModule. Is there a package which this code depends upon which also depends upon all the other packages it needs? If so, then this code should go into that top most package.

@Dr15Jones
Copy link
Contributor

After a quick look, I take back my objection to putting this in IOPool/Common.

@bbockelm
Copy link
Contributor Author

bbockelm commented Nov 4, 2015

@Dr15Jones - will open a second PR for CMSSW_8_0_x branch. However, I suspect we'll be asked for a backport to a release so I'll leave this open.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@bbockelm @Dr15Jones - being a completely new function, we can stick with 76x and rely on the forward port

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9515/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2015

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 11, 2015
Provide a utility for efficiently copying multiple files to the local
@cmsbuild cmsbuild merged commit c8fba75 into cms-sw:CMSSW_7_6_X Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants