Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Merger Issues #12260

Merged
merged 1 commit into from Nov 5, 2015
Merged

Fix Merger Issues #12260

merged 1 commit into from Nov 5, 2015

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Nov 4, 2015

  • Restore override
  • Remove printout as requested

@ianna
Copy link
Contributor Author

ianna commented Nov 4, 2015

@davidlange6 and @smuzaffar - this PR should fix last night merger issues.

@ianna
Copy link
Contributor Author

ianna commented Nov 4, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 4, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9462/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_0_X.

Fix Merger Issues

It involves the following packages:

Geometry/HGCalGeometry

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

@ianna
Copy link
Contributor Author

ianna commented Nov 4, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 5, 2015
@cmsbuild cmsbuild merged commit 4a0c823 into cms-sw:CMSSW_8_0_X Nov 5, 2015
@ianna ianna deleted the hgcal-merger-fix branch November 6, 2015 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants