Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Hydjet2Analyzer.cc #12263

Merged
merged 2 commits into from Jan 5, 2016
Merged

Delete Hydjet2Analyzer.cc #12263

merged 2 commits into from Jan 5, 2016

Conversation

wouf
Copy link
Contributor

@wouf wouf commented Nov 5, 2015

Delete Hydjet2Analyzer.cc from Hydjet to avoid multiple definition if it with Hydjet2

Delete Hydjet2Analyzer.cc from Hydjet  to avoid multiple definition if it with Hydjet2
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

A new Pull Request was created by @wouf for CMSSW_8_0_X.

Delete Hydjet2Analyzer.cc

It involves the following packages:

GeneratorInterface/HydjetInterface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
@cbaus, @mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9924/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: b639140
I found an error when building:

>> Compiling python modules cfipython/slc6_amd64_gcc493
>> Compiling python modules src/GeneratorInterface/HydjetInterface/python
>> All python modules compiled
gmake[1]: Leaving directory `/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-23-2300'
+ echo ALL_OK
ALL_OK


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12263/9924/summary.html

@covarell
Copy link
Contributor

covarell commented Dec 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10063/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

-1
Tested at: b639140
I found an error when building:

>> Compiling python modules cfipython/slc6_amd64_gcc493
>> Compiling python modules src/GeneratorInterface/HydjetInterface/python
>> All python modules compiled
gmake[1]: Leaving directory `/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-01-2300'
+ echo ALL_OK
ALL_OK


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12263/10063/summary.html

@covarell
Copy link
Contributor

covarell commented Dec 2, 2015

@wouf I do not understand this compilation problem, can you test it locally to see if you can reproduce it?

@davidlange6
Copy link
Contributor

@wouf - is there a fix planned for this error?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2016

Pull request #12263 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please check and sign again.

@wouf
Copy link
Contributor Author

wouf commented Jan 5, 2016

Sorry for late reaction, I corrected it.

@covarell
Copy link
Contributor

covarell commented Jan 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10423/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12263/10423/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 5, 2016
Delete Hydjet2Analyzer.cc
@cmsbuild cmsbuild merged commit 1864445 into cms-sw:CMSSW_8_0_X Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants