New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Me0 global reco selectors #12273
Me0 global reco selectors #12273
Conversation
A new Pull Request was created by @dnash86 for CMSSW_6_2_X_SLHC. Me0 global reco selectors It involves the following packages: DataFormats/MuonReco @cvuosalo, @slava77, @cmsbuild, @deguio, @danduggan, @vanbesien can you please review it and eventually sign? Thanks. |
please test Did you mean to put this on the 6_2_X_SLHC branch? I'll start testing, but this may have to go in on the SLHCDEV branch. |
The tests are being triggered in jenkins. |
@mark-grimes Ah, yes, this is probably more appropriate for the SLHCDEV branch. Should I re issue the PR there? (I guess I should send the PR to CMSSW_6_2_SLHCDEV_X, and not CMSSW_6_2_X_SLHC, is that correct?) |
Yes, that's correct. You may or may not have to rebase, see if the changes are as you would expect when you try the SLHCDEV pull request. |
The comparison to SLHCDEV seemed identical to the comparisons to SLHC, so I sent the PR as is. |
This PR brings ME0Muon production in SLHC releases in line with what is in 76X (in PR #11398).
Note: The main difference in its current state between this PR for SLHC releases and what was sent for 76X is that the ME0MuonCollProducer is still in Validation/RecoMuon, not moved to CommonTools/RecoAlgos as we were requested to do for 76X. This package has been used by multiple analyzers in SLHC as is, but if need be I can make the same move to CommonTools/RecoAlgos as was done in 76X. Let me know.