bsunanda:Run2-hcx47 Add trigger primitive version in geometry #12301

bsunanda · 2015-11-06T22:32:50Z

It may require new geometry records to test the DB version. XML versions work fine

cmsbuild · 2015-11-06T22:36:13Z

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

bsunanda:Run2-hcx47 Add trigger primitive version in geometry

It involves the following packages:

CondFormats/GeometryObjects
Geometry/CaloTopology
Geometry/HcalCommonData

@civanch, @diguida, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

ianna · 2015-11-09T15:29:29Z

@cmsbuild please test

cmsbuild · 2015-11-09T15:31:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9533/console

ianna · 2015-11-09T15:35:43Z

CondFormats/GeometryObjects/interface/HcalParameters.h

@@ -64,6 +64,7 @@ class HcalParameters {
  std::vector<int>    phigroup;
  std::vector<LayerItem> layerGroupEtaSim, layerGroupEtaRec;
  int                 topologyMode;
+  int                 triggerMode;


@bsunanda - this will require schema change. I'd suggest to use the topologyMode integer with mask to store/retrieve triggerMode.

Thanks - I shall do that. I shall give them 8 bits each right now.

From: Ianna Osborne [notifications@github.com]
Sent: 09 November 2015 16:35
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx47 Add trigger primitive version in geometry (#12301)

In CondFormats/GeometryObjects/interface/HcalParameters.hhttps://github.com//pull/12301#discussion_r44288078:

@@ -64,6 +64,7 @@ class HcalParameters {
std::vector phigroup;
std::vector layerGroupEtaSim, layerGroupEtaRec;
int topologyMode;

int triggerMode;

@bsunandahttps://github.com/bsunanda - this will require schema change. I'd suggest to use the topologyMode integer with mask to store/retrieve triggerMode.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12301/files#r44288078.

cmsbuild · 2015-11-09T16:39:03Z

-1

Tested at: ac60f58
I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12301/9533/summary.html

cmsbuild · 2015-11-09T17:36:56Z

Pull request #12301 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

bsunanda · 2015-11-09T17:42:19Z

@cmsbuild Please test

cmsbuild · 2015-11-09T17:46:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9543/console

cmsbuild · 2015-11-09T19:49:04Z

+1
Tested at: 33848b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12301/9543/summary.html

cmsbuild · 2015-11-09T20:44:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12301/9543/summary.html

bsunanda · 2015-11-10T00:06:40Z

@ianna Please see if it can be approved

ianna · 2015-11-10T06:44:25Z

@bsunanda - this PR should go in with a new DB payloads. A new GT is required for that. I'll start the process.

mmusich · 2015-11-10T09:14:25Z

@ianna, thanks, let's follow the usual procedure. First create the payload and then require them for 80X GTs. Currently we don't have yet 80X queues, let me open them.

bsunanda · 2015-11-10T11:19:56Z

@ianna The old payload will work as well. The default trigger mode is 0 which makes the old payload compatible. There is no need to wait till new payloads are made.

ianna · 2015-11-10T12:24:13Z

+1

cmsbuild · 2015-11-10T12:26:46Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-11-10T19:42:51Z

Geometry/CaloTopology/src/HcalTopology.cc

@@ -188,6 +199,28 @@ bool HcalTopology::validDetId(HcalSubdetector subdet, int ieta, int iphi,
  return validHcal(id);
 }

+bool HcalTopology::validHT(const HcalTrigTowerDetId& id) const {
+
+  if (id.iphi()<1 || id.iphi()>72 || id.ieta()==0) return false;


@bsunanda - there is no alternative to these hardwired numbers?

@davidlange6 AT the moment there is no way I can change the hardwired #'s. Please integrate it at the earliest because the HcalDetId changes are waiting for this PR to be integrated.

From: David Lange [notifications@github.com]
Sent: 10 November 2015 20:42
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx47 Add trigger primitive version in geometry (#12301)

In Geometry/CaloTopology/src/HcalTopology.cchttps://github.com//pull/12301#discussion_r44454520:

@@ -188,6 +199,28 @@ bool HcalTopology::validDetId(HcalSubdetector subdet, int ieta, int iphi,
return validHcal(id);
}

+bool HcalTopology::validHT(const HcalTrigTowerDetId& id) const {
+

if (id.iphi()<1 || id.iphi()>72 || id.ieta()==0) return false;

@bsunandahttps://github.com/bsunanda - there is no alternative to these hardwired numbers?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12301/files#r44454520.

davidlange6 · 2015-11-11T08:32:24Z

+1
but :(

bsunanda:Run2-hcx47 Add trigger primitive version in geometry

boudoul · 2015-12-02T13:14:43Z

Hi @bsunanda , could you please put by default the DebugLog to silent in HcalParametersFromDD.cc - The large number of 'cout' present in this file (maybe somewhere else too) is activated in production otherwise...

Add trigger primitive version in geometry

ac60f58

cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 6, 2015

cmsbuild added alca-pending db-pending geometry-pending pending-signatures tests-pending orp-pending comparison-pending labels Nov 6, 2015

ianna reviewed Nov 9, 2015
View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Nov 9, 2015

cmsbuild added tests-rejected and removed tests-started labels Nov 9, 2015

Take care of comments from Yana

33848b1

cmsbuild added tests-pending and removed alca-pending db-pending tests-rejected labels Nov 9, 2015

cmsbuild added tests-started and removed tests-pending labels Nov 9, 2015

cmsbuild removed the tests-started label Nov 9, 2015

cmsbuild added the tests-approved label Nov 9, 2015

cmsbuild added comparison-available and removed comparison-pending labels Nov 9, 2015

cmsbuild added geometry-approved fully-signed and removed geometry-pending pending-signatures labels Nov 10, 2015

davidlange6 reviewed Nov 10, 2015
View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Nov 11, 2015

cmsbuild added a commit that referenced this pull request Nov 11, 2015

Merge pull request #12301 from bsunanda/Run2-hcx47

15af33d

bsunanda:Run2-hcx47 Add trigger primitive version in geometry

cmsbuild merged commit 15af33d into cms-sw:CMSSW_8_0_X Nov 11, 2015

lgray mentioned this pull request Nov 16, 2015

HGC ToT Digitization Implementation (and corresponding RECO updates) #11880

Merged

cmsbuild added the orp-approved label Dec 2, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bsunanda:Run2-hcx47 Add trigger primitive version in geometry #12301

bsunanda:Run2-hcx47 Add trigger primitive version in geometry #12301

bsunanda commented Nov 6, 2015

cmsbuild commented Nov 6, 2015

ianna commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

ianna Nov 9, 2015

bsunanda Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

bsunanda commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

bsunanda commented Nov 10, 2015

ianna commented Nov 10, 2015

mmusich commented Nov 10, 2015

bsunanda commented Nov 10, 2015

ianna commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

davidlange6 Nov 10, 2015

bsunanda Nov 10, 2015

davidlange6 commented Nov 11, 2015

boudoul commented Dec 2, 2015

bsunanda:Run2-hcx47 Add trigger primitive version in geometry #12301

bsunanda:Run2-hcx47 Add trigger primitive version in geometry #12301

Conversation

bsunanda commented Nov 6, 2015

cmsbuild commented Nov 6, 2015

ianna commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

ianna Nov 9, 2015

Choose a reason for hiding this comment

bsunanda Nov 9, 2015

Choose a reason for hiding this comment

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

bsunanda commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

bsunanda commented Nov 10, 2015

ianna commented Nov 10, 2015

mmusich commented Nov 10, 2015

bsunanda commented Nov 10, 2015

ianna commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

davidlange6 Nov 10, 2015

Choose a reason for hiding this comment

bsunanda Nov 10, 2015

Choose a reason for hiding this comment

davidlange6 commented Nov 11, 2015

boudoul commented Dec 2, 2015