Fix consumes #1231
Fix consumes #1231
Conversation
|
A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_0_X. Fix consumes It involves the following packages: DQM/BeamMonitor @smuzaffar, @nclopezo, @danduggan, @rovere, @deguio, @eliasron can you please review it and eventually sign? Thanks. |
|
-1 4.22 step2 ----- Begin Fatal Exception 30-Oct-2013 17:18:18 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=DTLocalTriggerSynchTask label='dtTriggerSynchMonitor' Exception Message: MissingParameter: Parameter 'DCCInputTag' not found. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1090/summary.html |
|
Pull request #1231 was updated. @smuzaffar, @thspeer, @demattia, @danduggan, @rovere, @nclopezo, @rcastello, @deguio, @slava77, @eliasron can you please check and sign again. |
|
Marco your stuff does not merge anymore. Can you rebase it, please? |
|
oh my god, back to CVS conflicts.... I'll rebase it. M. |
|
|
|
git rebase CMSSW_7_0_X is even easier. the problem was related to a new plugin that went in into DQM/Physics. I'll test-again the pull and then I'll push my changes to my local repo, which will eventually be caught automatically here. Ciao, |
|
Pull request #1231 was updated. @smuzaffar, @thspeer, @demattia, @danduggan, @rovere, @nclopezo, @rcastello, @deguio, @slava77, @eliasron can you please check and sign again. |
|
Working @thspeer |
| @@ -148,3 +148,8 @@ class BSFitter { | |||
|
|
|||
| #endif | |||
|
|
|||
|
|
|||
| /* Local Variables: */ | |||
There was a problem hiding this comment.
What is the meaning of these lines? I see that in nearly every file here.
There was a problem hiding this comment.
It's simply custom-emacs settings. At some point I got bored of seeing ugly{,-formatted} code....
There was a problem hiding this comment.
Why not put them into your emacs config file ? We can't pollute every CMSSW source file with our own emacs settings !
There was a problem hiding this comment.
What's the ugly formatted code?
I've been in the emacs land since at least Y2K, never needed to add any junk to the source code to get something better out of emacs
There was a problem hiding this comment.
'Cause I edit CMSSW in 3 different envs and I do not have all of my .emacs in sync.
Anyway, I have no intention to start a religious war about editing/formatting and similar things, since the code is there to demonstrate we miserably failed on this.
Feel free to take them out and resubmit a pull request, if you deem so: for sure I do not want to discuss stylistic emacs-directives in comments.
By the way: getting rid of useless spaces at the end of a line is, IMHO, a good practice in general that I hoped would have been taken by everybody.
There was a problem hiding this comment.
Guys, are we serious or what?
If you do not like the comments, git rid of them but please stop discussing about them.
We can invest better our working hours.
There was a problem hiding this comment.
Ciao Marco,
Cleaning up of empty spaces and good indentation is really good.
Comments which apply to the code are also very good.
Text which points to nothing and has to be dragged around is bad.
What are these settings in emacs that you really need to have these
comments?
Could you please send a link or smth.
What if some other editors (vi, nedit, pico etc) need something like
that as well,
would we then go cycling over different preferences?
Please remove them.
Cheers
--slava
On 11/1/13, 2:24 PM, Marco Rovere wrote:
In RecoVertex/BeamSpotProducer/interface/BSFitter.h:
@@ -148,3 +148,8 @@ class BSFitter {
#endif
+/* Local Variables: */
Guys, are we serious or what?
If you do not like the comments, git rid of them but please stop
discussing about them.
We can invest better our working ours.—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/1231/files#r7368821.
Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)
There was a problem hiding this comment.
Dear Slava, all
unless you start an effort on removing similar customisations across full CMSSW, I'll not remove them.
By the way, we have already something similar for emacs, and a couple for both vim and vi.
If you don't like my pull, give a -1.
M.
There was a problem hiding this comment.
On 11/1/13, 3:02 PM, Marco Rovere wrote:
In RecoVertex/BeamSpotProducer/interface/BSFitter.h:
@@ -148,3 +148,8 @@ class BSFitter {
#endif
+/* Local Variables: */
Dear Slava, all
unless you start an effort on removing similar customisations across
full CMSSW, I'll not remove them.
By the way, we have already something similar for emacs, and a couple
for both vim and vi.If you don't like my pull, give a -1.
Dear Marco,
I'm just trying to understand the need or use cases for these.
I tried to check in lxr
https://cmssdt.cern.ch/SDT/lxr/search?v=CMSSW_7_0_0_pre6;string=show-trailing
and I don't see anything like the one from you in the release.
Which other customizations for editors did you have in mind.
Please clarify.
Thank you.
Cheers
--slava
M.
—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/1231/files#r7369520.
Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)
|
+1 |
|
ciao all, thanks, |
|
It also needs rebase by now... |
|
-1 |
|
This is an updated version of my original pull. @thspeer + @slava77: please take some time to review the changes I made related to the transition out of TFitterMinuit in ROOT6. From some preliminary test I made locally, it seems that everything is fine, but I'd appreciate a second, independent check. |
|
+1 |
|
How can you +1 something which does not merge? ;-) Please rebase. |
|
ciao @ktf am I doing something wrong? |
|
No, but life goes on and we are on the 12… ;-) |
|
Let's keep on rebasing it 'till it got approved ;) |
|
BTW, is the java stuff in DQM/BeamMonitor really used? |
|
yes, it is used for the online at the moment. |
|
+1 |
|
+1 |
|
ciao @demattia @rcastello thanks, |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Consumes migration -- Fix consumes in CMSSW
Consumes migration -- Fix consumes in CMSSW
…Debug L1TrackVertexAssociationProducer bug fix to stop accessing data after move
First bunch of getByToken changes in DQM packages.