Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save particleFlowRecHitHBHE and particleFlowRecHitHF collections #12324

Merged
merged 1 commit into from Nov 11, 2015

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Nov 9, 2015

Backport of #12300 for 76X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_7_6_X.

save particleFlowRecHitHBHE and particleFlowRecHitHF collections

It involves the following packages:

RecoParticleFlow/Configuration

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 9, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9546/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 9, 2015

+1

For #12324 b6ae995

Replacing the particleFlowRecHitHCAL collection with the particleFlowRecHitHBHE and particleFlowRecHitHF collections. There should be no change in monitored quantities. #12300 and #12325 are the 80X and 75X versions of this PR, and the latter has already been approved by Reco.

Jenkins tests against baseline CMSSW_7_6_X_2015-11-09-1100 show no significant differences, as expected. Extended tests done for #12300 also show no significant differences and an only very marginal increase in product sizes

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 11, 2015
save particleFlowRecHitHBHE and particleFlowRecHitHF collections
@cmsbuild cmsbuild merged commit a06d2ba into cms-sw:CMSSW_7_6_X Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants