Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused includes #1233

Merged
merged 1 commit into from Oct 31, 2013
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Oct 30, 2013

  • Remove spurious includes
  • Remove commented out lines

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_0_X.

Remove unused includes

It involves the following packages:

CondTools/Geometry

@ggovi, @smuzaffar, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@apfeiffer1
Copy link
Contributor

+1
if Jenkins agrees with me ...

On Wed, Oct 30, 2013 at 5:47 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @ianna https://github.com/ianna for
CMSSW_7_0_X.

Remove unused includes

It involves the following packages:

CondTools/Geometry

@ggovi https://github.com/ggovi, @smuzaffarhttps://github.com/smuzaffar,
@apfeiffer1 https://github.com/apfeiffer1, @nclopezohttps://github.com/nclopezocan you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@ktf https://github.com/ktf you are the release manager for this.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1233#issuecomment-27410300
.

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

ktf added a commit that referenced this pull request Oct 31, 2013
@ktf ktf merged commit ea1143a into cms-sw:CMSSW_7_0_X Oct 31, 2013
@ianna ianna deleted the static-analyser-errors-cleanup branch October 26, 2015 16:30
aloeliger added a commit to aloeliger/cmssw that referenced this pull request Apr 2, 2024
…eatefirmwarecfg

Phase 2 GTT fix null options for loading from buffers in F/W workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants