Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phase1Pixel era digi to/from raw additions #12361

Merged
merged 2 commits into from Nov 12, 2015

Conversation

mark-grimes
Copy link

Another tranche of the phase1Pixel era changes, adding on from #12275 and #12359 (I'm submitting them individually by package to try and ease integration). This one is for DigiToRaw and RawToDigi changes, equivalent to the customise_DigiToRaw and customise_RawToDigi functions.

There should be no change whatsoever unless the Run2_2017 era is active (the only top-level era that contains phase1Pixel).

@atricomi, @delaere

@boudoul do you still want to be pinged about tracker/pixel upgrade issues?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_8_0_X.

phase1Pixel era digi to/from raw additions

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

cmsbuild, please test

davidlange6 added a commit that referenced this pull request Nov 12, 2015
phase1Pixel era digi to/from raw additions
@davidlange6 davidlange6 merged commit 48a423f into cms-sw:CMSSW_8_0_X Nov 12, 2015
@mark-grimes
Copy link
Author

Is @cmsbuild having a meltdown?

@mark-grimes mark-grimes deleted the phase1PixelEraRawChanges branch November 12, 2015 17:44
@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor

For some reason, this PR was not completely tested by jenkins (it ran tests but was not able to upload the results to cmssdt) so it was trying to re-run it again and again, Looks like the last build https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12361/9694/summary.html was successful :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants