Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing event content CommonEventContent to FEVTSIM. #1237

Merged
merged 1 commit into from Nov 15, 2013

Conversation

vadler
Copy link

@vadler vadler commented Oct 30, 2013

Backport of #1216:
Add missing CommonEventContent to FEVTSIM and inherited FEVTDEBUG.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_6_2_X.

Add missing event content CommonEventContent to FEVTSIM.

It involves the following packages:

Configuration/EventContent

@smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@davidlt you are the release manager for this.

@Dr15Jones
Copy link
Contributor

@vadler Does this make FEVTSIM better match FEVT?

@vadler
Copy link
Author

vadler commented Nov 14, 2013

@Dr15Jones : Yepp. it has been integrated in 53X and 70X already.

@ktf
Copy link
Contributor

ktf commented Nov 15, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlt can you please take care of it?

@fabiocos
Copy link
Contributor

+1

@ghost ghost assigned davidlt Nov 15, 2013
davidlt added a commit that referenced this pull request Nov 15, 2013
Add missing event content CommonEventContent to FEVTSIM.
@davidlt davidlt merged commit b9294fe into cms-sw:CMSSW_6_2_X Nov 15, 2013
@vadler vadler deleted the 62X-fixEventContent branch February 21, 2014 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants