-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
800 me0 segment time pr #12383
800 me0 segment time pr #12383
Conversation
A new Pull Request was created by @pietverwilligen (Piet Verwilligen) for CMSSW_8_0_X. It involves the following packages: RecoLocalMuon/GEMRecHit @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
@Degano you are the release manager for this. |
ME0ModElecBkgParam6 = 1.50889e-06; | ||
|
||
// polynomial parametrisation of neutral (n+g) and electron background | ||
neuBkg.push_back(5.69e+06); neuBkg.push_back(-293334); neuBkg.push_back(6279.6); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do these parameters correspond to some universal law or cast in stone for some other reason?
If not, it seems more appropriate to define them via configuration parameters.
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 ^ /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-11-1100/src/SimMuon/GEMDigitizer/interface/ME0DigiPreRecoModel.h:47:16: note: overridden virtual function is here virtual void setup() = 0; ^ >> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-11-1100/src/RecoLocalMuon/GEMRecHit/src/GEMRecHitStandardAlgo.cc /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-11-1100/src/SimMuon/GEMDigitizer/src/ME0PreRecoGaussianModel.cc:14:14: error: unused variable 'cspeed' [-Werror,-Wunused-const-variable] const double cspeed = 29.9792458; // [cm/ns] ^ 1 warning and 1 error generated. In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-11-1100/src/SimMuon/GEMDigitizer/src/GEMDigiProducer.cc:13: In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-11-1100/src/SimMuon/GEMDigitizer/interface/GEMDigiProducer.h:9: you can see the results of the tests here: |
Pull request #12383 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
indeed. done now. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Pull request to include in 800 changes made in SLHCDev (PR #12370).