800 me0 segment time pr

[pietverwilligen]

Pull request to include in 800 changes made in SLHCDev (PR #12370).

• Cluster ME0Hits in a time window to create a ME0 Segment
• distribute neutron background uniformly in time in the ME0Digitizer

[cmsbuild]

A new Pull Request was created by @pietverwilligen (Piet Verwilligen) for CMSSW_8_0_X.

It involves the following packages:

RecoLocalMuon/GEMRecHit
RecoLocalMuon/GEMSegment
SimMuon/GEMDigitizer

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/L2's to mark it as on hold
• merge: L1 to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

do these parameters correspond to some universal law or cast in stone for some other reason?
If not, it seems more appropriate to define them via configuration parameters.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9660/console

[cmsbuild]

-1
Tested at: 48ae8e9
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

       ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-11-1100/src/SimMuon/GEMDigitizer/interface/ME0DigiPreRecoModel.h:47:16: note: overridden virtual function is here
  virtual void setup() = 0;
               ^
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-11-1100/src/RecoLocalMuon/GEMRecHit/src/GEMRecHitStandardAlgo.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-11-1100/src/SimMuon/GEMDigitizer/src/ME0PreRecoGaussianModel.cc:14:14: error: unused variable 'cspeed' [-Werror,-Wunused-const-variable]
const double cspeed = 29.9792458; // [cm/ns]
             ^
1 warning and 1 error generated.
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-11-1100/src/SimMuon/GEMDigitizer/src/GEMDigiProducer.cc:13:
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-11-1100/src/SimMuon/GEMDigitizer/interface/GEMDigiProducer.h:9:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12383/9660/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12383/9660/summary.html

[cmsbuild]

Pull request #12383 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[pietverwilligen]

indeed. done now.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10058/console

[cmsbuild]

+1
Tested at: 1912054
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12383/10058/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12383/10058/summary.html

[slava77]

+1

for #12383 1912054

• code changes look OK
• jenkins tests pass: compiles and no issues with the code. The workflows including new code are not running.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1