Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tracking MiniAOD validation #12405

Merged
merged 11 commits into from Nov 22, 2015
Merged

Update tracking MiniAOD validation #12405

merged 11 commits into from Nov 22, 2015

Conversation

makortel
Copy link
Contributor

This PR gives a major update to the tracking MiniAOD validation code.

  • Compare only charged PackedCandidates
  • Check normalizedChi2 only if PackedCandidate ndof != 0
    • it it is 0, its normalizedChi2 is 0 by construction
  • Check hasValidHitInFirstPixelBarrel() only if there are no lost inner hits
    • if there are, this information is not valid
  • Record the number of tracks used in the two cases above in the selection flow histogram
  • Monitor the overflow of pixel hits, strip hits, and total number of hits
  • Add (LogInfo) printout for track-PackedCandidate pairs where differences are outside tolerances
    • Helps to track them down
  • Detailed monitoring of the precision of packed floating point values
    • Try to catch and monitor under/overflows and sign changes
    • Limit monitoring mainly to the packed quantities (e.g. prefer covariance matrix elements over the corresponding "errors"), but provide monitoring of most interesting quantities where "equality within packing precision" is not expected (e.g. pT)

Tested in CMSSW_8_0_X_2015-11-11-2300, expecting changes in Tracking/PackedCandidate DQM folder.

@rovere @VinInn @arizzi @gpetruc

@makortel
Fix typo
f5be712
@makortel
Require PackedCandidate to be charged
d811d39
@makortel
Add printout for cases failing expectations
34f8e0a
@makortel
Check normalizedChi2 only if PackedCandidate ndof != 0
80112d7
@makortel
Check hasValidHitInFirstPixelBarrel only if there are no lost inner hits
3ce3b4f
@makortel
Extend selection flow
ee8fe64
@makortel
Take into account that PackedCandidate has maxima for the numbers of …
b4b6bdc 
…pixel and strip hits
@makortel
Rewrite monitoring of packed floating point values, extend to the ele…
1403a96 
…ments of the approximate covariance matrix

Created a helper class to monitor under/overflow of the packed
quantities (with specializations for float16 and liblogint). Limit
comparisons mainly to the exact quantities that are packed (e.g.
prefer covariances over errors), but compare also some "derived"
quantities when interesting. ("derived" = calculated from >= 1 packed
quantities)
@makortel
Downgrade printout to LogInfo
4077438
@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 12, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

DQM/TrackingMonitor

@cmsbuild, @danduggan, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/L2's to mark it as on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@VinInn
Copy link
Contributor

VinInn commented Nov 12, 2015

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9695/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 4077438
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12405/9695/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12405/9695/summary.html

@makortel
Copy link
Contributor Author

ping

@VinInn
Copy link
Contributor

VinInn commented Nov 18, 2015

@deguio please review

@makortel
Copy link
Contributor Author

I noticed only now that there was one unused function left (from which gcc warns), and one set of histograms had one extra bin.

@cmsbuild
Copy link
Contributor

Pull request #12405 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Nov 19, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9845/console

@deguio
Copy link
Contributor

deguio commented Nov 19, 2015

+1
looks ok to me

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: a953f14
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12405/9845/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12405/9845/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 22, 2015
@davidlange6
Merge pull request #12405 from makortel/trackingValidationMiniAODFix
d392d0f 
Update tracking MiniAOD validation
@davidlange6 davidlange6 merged commit d392d0f into cms-sw:CMSSW_8_0_X Nov 22, 2015
@makortel makortel mentioned this pull request Nov 26, 2015
Merged
@makortel makortel mentioned this pull request Jan 8, 2016
Merged
@makortel makortel deleted the trackingValidationMiniAODFix branch October 20, 2016 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@makortel @cmsbuild @VinInn @deguio @davidlange6