Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tracking MC validation scripts #12893

Merged
merged 40 commits into from Jan 16, 2016
Merged

Update tracking MC validation scripts #12893

merged 40 commits into from Jan 16, 2016

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jan 8, 2016

This PR updates the tracking MC validation scripts with the main changes being

  • Include V0 validation plots
  • Update PackedCandidate plots (followup to Update tracking MiniAOD validation #12405)
  • Support plots by originalAlgo and algoMask
    • When the histograms are available, e.g. MTV in standalone and trackingOnly modes
  • Support plots for seeds and built tracks
    • When the histograms are available, e.g. MTV in trackingOnly mode
  • Support comparing DQM files with different MTV subfolder naming conventions using a predefined fallback mechanism
    • E.g. to compare 80X and 62X_SLHC DQM files
  • Include timing plots (from FastTimerService)
  • Include tables in the summary report pages
  • Tuning/additions of plots
  • Decrease (stdout) verbosity

Based on 800pre4, standard workflows are not touched so no changes expected.

@rovere @VinInn

@makortel
Fix naming
426d341
@makortel
Update campaigns
5ed1419
@makortel
Add support for HTML tables
9d20329
@makortel
Reorder number of track summary plots to match the efficiencies/fake …
a8df9bb 
…rates/etc
@makortel
Fix typos
9ca714d
@makortel
Improve dqm folder/bin -> logical iteration name mapping
0462077 
Include support for old-style iteration naming
@makortel
Skip empty pages
9fcb079
@makortel
Add possibility for fallback histograms
a4db1f5
@makortel
Support list of possible values to xmin and xmax too
68be72f
@makortel
Add merge rate vs. Z and average vertex resolution, fix axis titles
5a36d47
@makortel
Support pT-cut track collections
104474f
@makortel
Add subfolder limiting to SimpleValidation too
12766f9
@makortel
Allow for plot customization from e.g. from trackingCompare.py script
56b85db
@makortel
Fix dzpvsigcut ROC plots
2692b46
@makortel
Support another set of track-PV association plots
221b28a
@makortel
Add V0 validation plots
2410042
@makortel
Decrease verbosity
03a344f
@makortel
Be stricter in tracking iteration name detection
d28bdbe
@makortel
Support originalAlgo and algoMask
711e36a 
Produce their summaries only if they exist
@makortel
Create ROC curves only if both axes have non-zero values
7a1dd0e
@makortel
Don't make directories nor HTML entries for empty plotterFolder
446fe07
@makortel
Add support for seeding and track building plots
ed0eab3 
Make only subset of plots for them. Support also
initialStepPreSplitting.
@makortel
Support the occasional extended-statistics RelVals
f0b6b33
@makortel
Fix calculation of number of rows
5048196
@makortel
Allow specifying if sample has pileup in SimpleValidation
126c569
@makortel
Support phase1 validation
40a8fef
@makortel
Add support for comparing DQM files with different subdirectory naming
482d8e4 
As an example, comparison to 620_SLHC
@makortel
Generalize more the ratio calculation
f883787
@makortel
Resurrect timing plots, add table
e1db880 
ConvStep timing is monitored separately.
@makortel
Set default draw style to "EP"
db4fa13 
That was implicitly the default. But in case the histograms have no
uncertainties set, ROOT defaults to HIST, and I want to have "EP"
always.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

Validation/RecoTrack
Validation/RecoVertex

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@makortel makortel mentioned this pull request Jan 8, 2016
Merged
@VinInn
Copy link
Contributor

VinInn commented Jan 8, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10447/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

+1
Tested at: 41c7527
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12893/10447/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12893/10447/summary.html

@makortel makortel mentioned this pull request Jan 12, 2016
Merged
@makortel
Copy link
Contributor Author

Could DQM (@deguio, @vanbesien) please review and sign? Thanks.

@deguio
Copy link
Contributor

deguio commented Jan 15, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 16, 2016
@cmsbuild
Merge pull request #12893 from makortel/trackingValidation_v5
4a675cd 
Update tracking MC validation scripts
@cmsbuild cmsbuild merged commit 4a675cd into cms-sw:CMSSW_8_0_X Jan 16, 2016
cmsbuild added a commit that referenced this pull request Jan 16, 2016
@cmsbuild
Merge pull request #12893 from makortel/trackingValidation_v5
668acb8
@makortel makortel deleted the trackingValidation_v5 branch October 20, 2016 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@makortel @cmsbuild @VinInn @deguio @davidlange6