bsunanda:Run2-hcx51 Remove wrong constructor of hcalTopology #12444
Conversation
|
A new Pull Request was created by @bsunanda for CMSSW_8_0_X. It involves the following packages: SimCalorimetry/HcalSimAlgos @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| << " Timebin " << correction->timeBin(*hitItr) <<std::endl; | ||
| } | ||
| } | ||
| class HcalDigitizerTest : public edm::EDAnalyzer { |
There was a problem hiding this comment.
@bsunanda - you should use one:: instead of legacy analyser
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #12444 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test From: cmsbuild [notifications@github.com] Pull request #12444#12444 was updated. @cmsbuildhttps://github.com/cmsbuild, @civanchhttps://github.com/civanch, @mdhildrethhttps://github.com/mdhildreth, @davidlange6https://github.com/davidlange6 can you please check and sign again. — |
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
bsunanda:Run2-hcx51 Remove wrong constructor of hcalTopology
No description provided.