Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the Hadronizer and scripts to work with Sherpa 2.2.0 #12462

Merged
merged 5 commits into from Nov 25, 2015

Conversation

thuer
Copy link
Contributor

@thuer thuer commented Nov 17, 2015

Changed the Interface and Scripts to work with Sherpa 2.2.0

The changes to the Sherpack retrieving method (from frontier to normal cp) #11985 are not yet merged, should I cherry-pick the commits to this pull request and update the RelVal fragments?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thuer (Sebastian Thüer) for CMSSW_8_0_X.

It involves the following packages:

GeneratorInterface/SherpaInterface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@bendavid
Copy link
Contributor

Yes, sorry, we missed re-signing that one after the last update. Please include those commits here (since they are no longer needed in 76x)

@thuer
Copy link
Contributor Author

thuer commented Nov 17, 2015

Sorry for the many small commits, they were already in the previous pull request and it was easier to just cherry pick them

@cmsbuild
Copy link
Contributor

Pull request #12462 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please check and sign again.

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9923/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 25, 2015
Changed the Hadronizer and scripts to work with Sherpa 2.2.0
@cmsbuild cmsbuild merged commit 629a116 into cms-sw:CMSSW_8_0_X Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants